Parameter expansion does not work across merged lists #13
Comments
madduck
added a commit
that referenced
this issue
Dec 2, 2013
This was easier than thought. The problem: If two lists are merged (extended), and those lists use RefValues, then expansion (interpolation) won't work. The reason is that the DictPath includes the list indices, e.g. apt_repos:0:uri and those indices start at 0 for every list. Now, when two lists are merged, the reference to the base RefValue (in Parameters._occurrences) is overwritten by the RefValue of the mergee, causing it to not get expanded later. Instead of just updating self._occurrences, we can populate it as we update scalars, and on extending lists, we can add an offset to the index in the path of the mergee. Still: DictPath should go. One day… Closes: #13 Signed-off-by: martin f. krafft <madduck@madduck.net>
madduck
added a commit
that referenced
this issue
Dec 2, 2013
This was easier than thought. The problem: If two lists are merged (extended), and those lists use RefValues, then expansion (interpolation) won't work. The reason is that the DictPath includes the list indices, e.g. apt_repos:0:uri and those indices start at 0 for every list. Now, when two lists are merged, the reference to the base RefValue (in Parameters._occurrences) is overwritten by the RefValue of the mergee, causing it to not get expanded later. Instead of just updating self._occurrences, we can populate it as we update scalars, and on extending lists, we can add an offset to the index in the path of the mergee. Still: DictPath should go. One day… Closes: #13 Signed-off-by: martin f. krafft <madduck@madduck.net>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Comment to self: if two lists are merged (extended), and those lists use
RefValues, then expansion (interpolation) won't work. The reason is that theDictPathincludes the list indices, e.g.apt_repos:0:uriand those indices start at 0 for every list. Now, when two lists are merged, the reference to the baseRefValue(inParameters._occurrences) is overwritten by theRefValueof the mergee, causing it to not get expanded later.DictPathis a gross hack, and I wish I didn't need it. One way around it would be to teach the output drivers to translateRefValueinstances into their values once resolved. If that were the case, then we'd only need a list ofRefValues, not a mapping betweenRefValuesand their path, which is used to replace the with the value once interpolated.Another solution might be to let list extension augment the indices in the
DictPaths.The text was updated successfully, but these errors were encountered: