Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add starter scaffolds #73

Merged
merged 13 commits into from
Oct 5, 2020
Merged

Add starter scaffolds #73

merged 13 commits into from
Oct 5, 2020

Conversation

rasienko
Copy link
Contributor

@arist0tl3 can you take a look at these changes to the starter guide? I added 3 new frameworks and updated the existing samples to address feedback about inconsistencies. There are a lot of changes to this page and it could use another pair of eyes. Thanks!

src/asciidoc/docs/getting-started/startGuide1.adoc Outdated Show resolved Hide resolved
src/asciidoc/docs/getting-started/startGuide1.adoc Outdated Show resolved Hide resolved
src/asciidoc/docs/getting-started/startGuide1.adoc Outdated Show resolved Hide resolved
src/asciidoc/docs/_includes/startGuide1Angular.js Outdated Show resolved Hide resolved
src/asciidoc/docs/_includes/startGuide1Angular.js Outdated Show resolved Hide resolved
@rasienko
Copy link
Contributor Author

rasienko commented Oct 1, 2020

@arist0tl3 I believe all the feedback has been addressed and starter guide 1 is ready to publish. Please do a quick check and confirm. Then, I think we should merge this pr so we can handle starter guide 2 as a separate PR (this one is getting too big).

@rasienko rasienko merged commit 9e01a3e into master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants