Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable OpenMP by default (enable it only if USEOPENMP=1) #900

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

valassi
Copy link
Member

@valassi valassi commented Jul 10, 2024

Hi Olivier, this is a followup to #758.

As discussed at the meeting yesterday, I am disabling OpenMP by default.

It is now enabled only if USEOPENMP=1.

Can you please check and approve? Thanks
Andrea

Copy link
Member

@oliviermattelaer oliviermattelaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks, this can be merged.

Thanks a lot,

Olivier

@valassi
Copy link
Member Author

valassi commented Jul 16, 2024

Thanks a lot to you @oliviermattelaer ! Merging now

@valassi valassi merged commit d23edb5 into madgraph5:master Jul 16, 2024
163 of 169 checks passed
valassi added a commit to valassi/madgraph4gpu that referenced this pull request Jul 16, 2024
valassi added a commit to valassi/madgraph4gpu that referenced this pull request Jul 16, 2024
…aster with OMP madgraph5#900 and submod madgraph5#897) into gtest

Fix conflicts in epochX/cudacpp/gg_tt.mad/CODEGEN_mad_gg_tt_log.txt
  git checkout clang gg_tt.mad/CODEGEN_mad_gg_tt_log.txt

Note: MG5AMC has been updated including mg5amcnlo#107
valassi added a commit to valassi/madgraph4gpu that referenced this pull request Jul 16, 2024
…aster with clang madgraph5#905, OMP madgraph5#900 and submod madgraph5#897) into gtest

Fix conflicts in epochX/cudacpp/gg_tt.mad/CODEGEN_mad_gg_tt_log.txt
  git checkout clang gg_tt.mad/CODEGEN_mad_gg_tt_log.txt

Note: MG5AMC has been updated including mg5amcnlo#107
valassi added a commit to valassi/madgraph4gpu that referenced this pull request Jul 17, 2024
…from fpe PR madgraph5#874 and omp PR madgraph5#900 for OpenMP issue madgraph5#758 - bldall and runTest succeds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why do we need to compile with openmp flag?
2 participants