-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable OpenMP by default (enable it only if USEOPENMP=1) #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enable OpenMP only if USEOPENMP=1 (madgraph5#758)
… OpenMP only if USEOPENMP=1 (madgraph5#758)
…eam/master for easier merging git checkout upstream/master $(git ls-tree --name-only HEAD */CODEGEN*txt)
This was referenced Jul 10, 2024
valassi
added a commit
to valassi/madgraph4gpu
that referenced
this pull request
Jul 12, 2024
…ault madgraph5#758) into gtest
oliviermattelaer
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect thanks, this can be merged.
Thanks a lot,
Olivier
Thanks a lot to you @oliviermattelaer ! Merging now |
valassi
added a commit
to valassi/madgraph4gpu
that referenced
this pull request
Jul 16, 2024
…h5#900 and submod madgraph5#897) into clang
valassi
added a commit
to valassi/madgraph4gpu
that referenced
this pull request
Jul 16, 2024
…aster with OMP madgraph5#900 and submod madgraph5#897) into gtest Fix conflicts in epochX/cudacpp/gg_tt.mad/CODEGEN_mad_gg_tt_log.txt git checkout clang gg_tt.mad/CODEGEN_mad_gg_tt_log.txt Note: MG5AMC has been updated including mg5amcnlo#107
valassi
added a commit
to valassi/madgraph4gpu
that referenced
this pull request
Jul 16, 2024
…aster with clang madgraph5#905, OMP madgraph5#900 and submod madgraph5#897) into gtest Fix conflicts in epochX/cudacpp/gg_tt.mad/CODEGEN_mad_gg_tt_log.txt git checkout clang gg_tt.mad/CODEGEN_mad_gg_tt_log.txt Note: MG5AMC has been updated including mg5amcnlo#107
valassi
added a commit
to valassi/madgraph4gpu
that referenced
this pull request
Jul 17, 2024
…from fpe PR madgraph5#874 and omp PR madgraph5#900 for OpenMP issue madgraph5#758 - bldall and runTest succeds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Olivier, this is a followup to #758.
As discussed at the meeting yesterday, I am disabling OpenMP by default.
It is now enabled only if USEOPENMP=1.
Can you please check and approve? Thanks
Andrea