Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: e2e tests #52

Merged
merged 3 commits into from
Dec 10, 2019
Merged

feat: e2e tests #52

merged 3 commits into from
Dec 10, 2019

Conversation

rishabhKalakoti
Copy link
Contributor

@rishabhKalakoti rishabhKalakoti commented Dec 10, 2019 •
edited by jamesgeorge007
Loading

Description

e2e tests for
teachcode -h || teachcode --help
teachcode junkcmd [unknown commands]
teachcode -a [unknown option]

Addresses #28

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jamesgeorge007 jamesgeorge007 added the enhancement New feature or request label Dec 10, 2019
jamesgeorge007
jamesgeorge007 requested changes Dec 10, 2019
View reviewed changes
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the prettier issues.

@jamesgeorge007 jamesgeorge007 merged commit c16cba6 into madlabsinc:next Dec 10, 2019
@jamesgeorge007 jamesgeorge007 added this to the v1.3.0 milestone Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgeorge007 jamesgeorge007 jamesgeorge007 approved these changes

Assignees

@rishabhKalakoti rishabhKalakoti

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rishabhKalakoti @jamesgeorge007