close() function in destructor of Madzipper causes 'Invalid or uninitialized Zip object' with PHP 8

[ssbrandsma]

Sample code to reproduce:

$zipper = new Madzipper;
$zipper->make($relativeFolder . $filenameZip)
               ->addString($filename, $qms_data)
               ->close();
$zipper = null; // close is also called via destructor of Madzipper

ZipRepository.php

    /**
     * Closes the archive and saves it
     */
    public function close()
    {
        @$this->archive->close();      //  <----  error surpressed 
    }

In PHP 8.0, the @ operator does not suppress certain types of errors that were silenced prior to PHP 8.0.

Until this is fixed, I don't call close() after adding the string but let de destructor close it.

[scs-ben]

Thank you for posting this workaround!

[smknstd]

Warning This function has been DEPRECATED as of PHP 8.0.0. Relying on this function is highly discouraged.

https://www.php.net/manual/fr/function.zip-close.php

[ggmanuilov]

I migrate application from php7.2 to php8 and get this problem.
After add this checking my tests work correnctly.

   /**
     * Closes the archive and saves it.
     */
    public function close()
    {
        $this->archive->filename and $this->archive->close();
    }

How do you think it correctly checking?

[theimerj]

Should be fixed in v1.2.1 and v1.3.1. Thank you for reporting.

[melikadze]

Its not fixed at all

[theimerj]

@melikadze can you open a PR with a proposed fix? I do not have time to look into that atm.

[sidneygijzen]

Just to confirm; unfortunately I also am running into the same error Uncaught ValueError: Invalid or uninitialized Zip object when trying to call close() on the zipfile. The app is running PHP 8.0.20. Applying the aforementioned workaround (in the first post) fixes the issue.

[scs-ben]

@theimerj I created a PR to address this by catching the error