-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artisan seems to try to close the zip and the @ doesn't suppress the error #29
Comments
Currently am working around the issue by overriding madzipper
|
@danschumann the error you're getting looks a lot like the issue mentioned in #21. Perhaps the workaround posted there also works in your case without having to override Madzipper? |
Apparently, there are ways to close the Zip object when it's not expected to be closed. This would address madnest#21 and madnest#29
I basically moved your override into Madzipper: #30 |
Should be working with #30 until I find a more permanent solution. I am planning to rewrite the whole package anyway for v2 with more fluent API. I will open a discussion about the plan when the time comes. :) |
It seems like the @ variable is used to suppress error, but in php 8.1 it doesn't seem to work anymore, or perhaps they changed the default?
The text was updated successfully, but these errors were encountered: