Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies #268

Merged
merged 6 commits into from Feb 27, 2020
Merged

Update Dependencies #268

merged 6 commits into from Feb 27, 2020

Conversation

madoar
Copy link
Owner

@madoar madoar commented Feb 25, 2020

This PR updated most of the development dependencies to the most current version

@madoar
Copy link
Owner Author

madoar commented Feb 25, 2020

@earshinov when running npm run build on this branch I get the following deprecation warnings in the output:

...
> scss-bundle

DEPRECATION WARNING: As of Dart Sass 2.0.0, !global assignments won't be able to
declare new variables. Consider adding `$aw-param-indicator-width: null` at the root of the
stylesheet.

    ╷
273 │   $aw-param-indicator-width: $width !global;
    │   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
    stdin 273:3   aw-define-style()
    stdin 393:13  aw-define-styles()
    stdin 600:1   root stylesheet

DEPRECATION WARNING: As of Dart Sass 2.0.0, !global assignments won't be able to
declare new variables. Consider adding `$aw-param-indicator-height: null` at the root of the
stylesheet.

    ╷
274 │   $aw-param-indicator-height: $height !global;
    │   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
    stdin 274:3   aw-define-style()
    stdin 393:13  aw-define-styles()
    stdin 600:1   root stylesheet

DEPRECATION WARNING: As of Dart Sass 2.0.0, !global assignments won't be able to
declare new variables. Consider adding `$aw-param-indicator-border-width: null` at the root of the
stylesheet.

    ╷
275 │   $aw-param-indicator-border-width: $border-width !global;
    │   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
    stdin 275:3   aw-define-style()
    stdin 393:13  aw-define-styles()
    stdin 600:1   root stylesheet


> angular-archwizard@6.0.0-develop extract-scss-variables /home/marc/git/angular-archwizard
> extract-scss-variables ./dist/archwizard.scss ./dist/variables.scss


> angular-archwizard@6.0.0-develop build-css /home/marc/git/angular-archwizard
> node-sass ./dist/archwizard.scss ./dist/archwizard.css
...

This seems to be linked to #239. In #239 you mentioned that other usages of !global are needed. I think you mean these occurrences right? Do you have a suggestion or solution how to deal with these deprecation warnings? I don't think it is a good idea to simply ignore them

@earshinov
Copy link
Contributor

I think the problem is that $aw-param-*** variables are not declared at the top level, which sets them apart from other variables we use with !global. I think we should follow the recommendations from the warning message and declare the $aw-param-*** variables at the top level.

@madoar
Copy link
Owner Author

madoar commented Feb 27, 2020

Ok I will fix this in a separate PR

@madoar madoar merged commit 6b86beb into develop Feb 27, 2020
@madoar madoar deleted the update-miscellaneous-dependencies branch February 27, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants