Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the SCSS global variable warnings #269

Merged
merged 1 commit into from Feb 28, 2020
Merged

Conversation

madoar
Copy link
Owner

@madoar madoar commented Feb 27, 2020

This PR fixes the warnings:

DEPRECATION WARNING: As of Dart Sass 2.0.0, !global assignments won't be able to
declare new variables. Consider adding `$aw-param-indicator-width: null` at the root of the
stylesheet.

    ╷
273 │   $aw-param-indicator-width: $width !global;
    │   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
    stdin 273:3   aw-define-style()
    stdin 393:13  aw-define-styles()
    stdin 600:1   root stylesheet

DEPRECATION WARNING: As of Dart Sass 2.0.0, !global assignments won't be able to
declare new variables. Consider adding `$aw-param-indicator-height: null` at the root of the
stylesheet.

    ╷
274 │   $aw-param-indicator-height: $height !global;
    │   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
    stdin 274:3   aw-define-style()
    stdin 393:13  aw-define-styles()
    stdin 600:1   root stylesheet

DEPRECATION WARNING: As of Dart Sass 2.0.0, !global assignments won't be able to
declare new variables. Consider adding `$aw-param-indicator-border-width: null` at the root of the
stylesheet.

    ╷
275 │   $aw-param-indicator-border-width: $border-width !global;
    │   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
    stdin 275:3   aw-define-style()
    stdin 393:13  aw-define-styles()
    stdin 600:1   root stylesheet

See also #268 (comment)

@madoar madoar merged commit 6e1fe50 into develop Feb 28, 2020
@madoar madoar deleted the fix-scss-global-warning branch February 28, 2020 20:32
@gethari
Copy link

gethari commented Mar 19, 2020

Can this fix be implemented for people who are using the package for Angular 8 as well ?

@madoar
Copy link
Owner Author

madoar commented Mar 19, 2020

It kind of depends on #280. Creating a new release is a lot of work, independent of whether it is a bugfix, minor or major release. This PR simply solves a warning. It is kind of a cosmetic change so I wouldn't want to put in the required effort just to create a new bugfix release (5.0.1) for this PR. If #280 gets solved then it would be easy to apply this PR to a 5.x.y branch which can be based on the fix for #280 as well.

madoar added a commit that referenced this pull request May 10, 2020
- fix the scss version 2 warning that global variables need to be declared at the root
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants