make behaviour in input, select, and textarea configurable. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madrobby
added a commit
that referenced
this pull request
Mar 21, 2012
--- Ive moved the test for INPUT, SELECT and TEXTAREA into a property of `key`, `key.prekeydown` if the function assigned to `prekeydown` returns `false`, then keymaster ignores the key press. you can also change scope in this function, so you can have a scope the shortcuts that work inside an input. one quirk is that keys in the all scope still work when youve changed the scope. so, if you want shortcuts that do not apply inside an input, you need to assign them to a particular scope. Conflicts: keymaster.min.js
This was referenced Mar 21, 2012
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've moved the test for INPUT, SELECT and TEXTAREA into a property of
key,key.prekeydownif the function assigned to
prekeydownreturnsfalse, then keymaster ignores the key press.you can also change scope in this function, so you can have a scope the shortcuts that work inside an input.
one quirk is that keys in the 'all' scope still work when you've changed the scope.
so, if you want shortcuts that do not apply inside an input, you need to assign them to a particular scope.