Move $.fn.submit to form.js

madrobby · Jul 13, 2011 · a29196e · a29196e
1 parent 2945368
commit a29196e
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 20 deletions.
diff --git a/src/form.js b/src/form.js
@@ -59,4 +59,21 @@
     return result.join('&');
   };
 
+  // ### $.fn.submit
+  //
+  // Trigger submit event for form
+  //
+  // *Example:*
+  //
+  //     $('#login_form').submit();
+  //
+  $.fn.submit = function () {
+    return this.each(function () {
+      try {
+        this.submit();
+        return;
+      } catch(e) {};
+    });
+  }
+
 })(Zepto);
diff --git a/src/zepto.js b/src/zepto.js
@@ -353,15 +353,6 @@ var Zepto = (function() {
        ((when !== undefined && !when) || $(this).hasClass(newName)) ?
          $(this).removeClass(newName) : $(this).addClass(newName)
       });
-    },
-    submit: function () {
-      return this.each(function () {
-        try {
-          // Submit first form element
-          this.submit();
-          return;
-        } catch(e) {};
-      });
     }
   };
 

diff --git a/test/form.html b/test/form.html
@@ -85,6 +85,16 @@ <h1>Zepto DOM unit tests</h1>
         t.assertEqual(Function, loginForm.serialize.constructor);
         t.assertEqual( 'string', typeof loginForm.serialize() );
         t.assertEqual( 'email=koss%40nocorp.me&password=123456', loginForm.serialize() );
+      },
+
+      testFormSubmit: function (t) {
+        var formSubmitted = false;
+        $('#login_form').get(0).submit = function (e) {
+          formSubmitted = true;
+          e.preventDefault();
+        };
+        $('#login_form').submit();
+        t.assert(formSubmitted);
       }
 
     });

diff --git a/test/zepto.html b/test/zepto.html
@@ -1533,17 +1533,6 @@ <h1>Zepto DOM unit tests</h1>
         t.assert(foo);
       },
 
-      testFormSubmit: function (t) {
-        // Test form submit action
-        var formSubmitted = false;
-        $('#some_form').get(0).submit = function (e) {
-          formSubmitted = true;
-          e.preventDefault();
-        };
-        $('#some_form').submit();
-        t.assert(formSubmitted);
-      },
-
       testSlice: function (t) {
         var $els = $("#slice_test div");
         t.assertEqual($els.slice().length, 3);