Implement isDefaultPrevented event method for AngularJS compatibility #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm not sure. This entails calling |
|
Well, right. But how about smth like this? It solves the issue with Angular and costs only one extra line. On the other hand it works only for Chrome 18+, Firefox 6+. |
|
We now support IE 10 so any code that we add should be supported in all browsers. |
|
I've just checked it in IE10 and fortunately it works. |
mislav
added a commit
that referenced
this pull request
Dec 1, 2013
Previously, these methods were only available in event delegation handlers: - isDefaultPrevented - isPropagationStopped - isImmediatePropagationStopped For compatibility with jQuery and for avoiding cross-browser differences, now every event is extended with these methods before it's passed to an event handler. Alt. for #864
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AngularJS relies on a proprietary method - isDefaultPrevented, so how about implementing this method?
It costs only 3 additional lines =)