Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py.typed to package #156

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Conversation

akshayphdk
Copy link
Contributor

I'm trying to use python-json-logger in my project, but mypy is surfacing this error:

error: Skipping analyzing "pythonjsonlogger": module is installed, but missing library stubs or py.typed marker
note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

I believe there is an open issue related to this: #118
My guess why this continues to happen even though py.typed exists in the repo is because it isn't added to the package.

@bringhurst
Copy link
Contributor

Just fyi, this marker was intentionally excluded in #129 since typing was incomplete at the time.

Before this is merged in, it would probably be a good idea to set disallow_untyped_defs = true in setup.cfg and fix anything it complains about.

@madzak
Copy link
Owner

madzak commented Nov 29, 2022

Thanks, will evaluate bringhursts note after I'm done merging pull requests.

@madzak madzak merged commit 6c992fd into madzak:master Nov 29, 2022
@mike-oakley
Copy link

@madzak any chance you could cut a release which includes this fix? 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants