Skip to content

Commit

Permalink
Fix failing behave tests (jrnl-org#447)
Browse files Browse the repository at this point in the history
The keyring package broke backward compatibility in version 8.0 by
moving some keyring backends to another package, keyrings.alt, as
documented in the changelog [1].

This change broke behave tests which were trying to use
keyring.backends.file.PlaintextKeyring - no longer existing in keyring
package.

This commit adds the keyrings.alt package as dependency so that the
PlaintextKeyring class can be used.

[1] https://pythonhosted.org/keyring/history.html#id22
  • Loading branch information
radomirbosak authored and maebert committed Jan 4, 2017
1 parent a6f6d7e commit 3f55633
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 2 additions & 1 deletion features/steps/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
import codecs
import json
import keyring
keyring.set_keyring(keyring.backends.file.PlaintextKeyring())
import keyrings
keyring.set_keyring(keyrings.alt.file.PlaintextKeyring())
try:
from io import StringIO
except ImportError:
Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ def dist_github():
"six>=1.6.1",
"tzlocal>=1.1",
"keyring>=3.3",
"keyrings.alt>=1.3",
] + [p for p, cond in conditional_dependencies.items() if cond],
extras_require = {
"encrypted": "pycrypto>=2.6"
Expand Down

0 comments on commit 3f55633

Please sign in to comment.