filter-brightness-als: support droid4 ALS #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the Droid 4 ALS just works. This PR adds support for it, but note that:
|
|
(So ... don't merge as it) |
MerlijnWajer
changed the title
|
Updated PR, now works quite well, at least in direct sunlight. Will test in a dark room tonight, but I think it should be ready for merging. Perhaps we can also attempt a generic way to do this, if/when a max ALS value is reported in sysfs, and we know the scale. But the sysfs interfaces are not generic/standardised, so that doesn't help... |
MerlijnWajer
force-pushed
the
droid4-als
branch
2 times, most recently
from
7a99032
to
c1998e2
Compare
|
Wondering if we should use |
MerlijnWajer
force-pushed
the
droid4-als
branch
4 times, most recently
from
12ce25d
to
06fd83c
Compare
Supporting dimming the display backlight brightness, the LEDs and the keyboard backlight based upon the Ambient Light Sensor in the Droid 4. The values in the profiles are work in progress, I have yet to test very dark rooms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting dimming the display backlight brightness, the LEDs and the
keyboard backlight based upon the Ambient Light Sensor in the Droid 4.
The values in the profiles are very much work in progress, and you
currently need a very strong light to be able to see this display when
the brightness level is not set to a high value.
Probably the mapping needs to be inverted, and I need to do further
testing based upon ambient light values.