Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DateTime for all Modules #69

Closed
3 tasks done
maennchen opened this issue Jun 11, 2020 · 0 comments · Fixed by #129
Closed
3 tasks done

Support DateTime for all Modules #69

maennchen opened this issue Jun 11, 2020 · 0 comments · Fixed by #129
Labels
enhancement help wanted

Comments

@maennchen
Copy link
Owner

maennchen commented Jun 11, 2020 •
edited

Support to use DateTime as well as NaiveDateTime.

Needed to enable option 4 of quantum-elixir/quantum-core#407
This was referenced Aug 4, 2020
Merged
Closed
@shaolang shaolang mentioned this issue Feb 12, 2024
Merged
@maennchen maennchen linked a pull request Feb 12, 2024 that will close this issue
Date helper datetime support #129
Merged
maennchen added a commit that referenced this issue Feb 13, 2024
@shaolang @maennchen
Date helper datetime support (#69) (#129)
ad3d7e4 
* DateHelper DateTime Support

* Add mix_test_watch as dev dep

* Simplify date_helper with extracted add/3 and days_in_year/1

* Handle daylight savings start and end calculations

* Fix formatting issues

* Use DateTime.from_naive/2 to determine ambiguity

* Remove private as dep

* Reinstate date type in DateChecker

* Replace all DateHelper.date with DateChecker.date in date_checker

* Change to using if, instead of case, in date_helper.add/3

* Fix inc_year/1 and dec_year/1 in date_helper

* Move time zone database setup to config.exs

* Replace all :calendar.day_of_the_week with Date.day_of_week in date_helper

* Simplify DateHelper.dec_month/1

* Address lingering issues from code review

---------

Co-authored-by: Jonatan Männchen <jonatan@maennchen.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Date helper datetime support shaolang/crontab
1 participant
@maennchen