Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateHelper DateTime Support #72

Closed
wants to merge 1 commit into from
Closed

Conversation

maennchen
Copy link
Owner

Partial Implementation of #69

TODO: How to fix the comments? Incrementing / Decrementing Seconds will not work properly.

@coveralls

This comment was marked as outdated.

@coveralls

This comment was marked as outdated.

@shaolang
Copy link
Contributor

Is there any particular reason why using :day, :hour, :minute, etc as the unit isn't considered?

@maennchen
Copy link
Owner Author

@shaolang I honestly don't remember why thing are how they are. I stopped looking at this years ago and can't quite remember why.

You're welcome to pick this back up and look at the details.

One thing to be very careful of is that it behaves correct both around leap seconds and time zone changes. (summer / winter time etc.)

@coveralls
Copy link

coveralls commented Jan 30, 2024

Coverage Status

coverage: 96.257% (-0.5%) from 96.736%
when pulling 9fb0fba on date_helper_datetime_support
into 9122b11 on main.

@maennchen
Copy link
Owner Author

Is there any particular reason why using :day, :hour, :minute, etc as the unit isn't considered?

@shaolang Yes: the units were not yet supported back in 2020. This is a newer feature from Elixir 1.14.

Given that, it should probably be easier to implement this.

@shaolang
Copy link
Contributor

Is there any particular reason why using :day, :hour, :minute, etc as the unit isn't considered?

@shaolang Yes: the units were not yet supported back in 2020. This is a newer feature from Elixir 1.14.

Given that, it should probably be easier to implement this.

ah... that explains it.

LOL... sorry, I couldn't help in doing this in the past 2 weeks 'cos work commits. I'll see what else I can help on.

@maennchen
Copy link
Owner Author

Closed in favor of #129

@maennchen maennchen closed this Feb 12, 2024
@maennchen maennchen deleted the date_helper_datetime_support branch February 13, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants