[APPINT-1339] Improving Connector Framework #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hhemanth
commented
Nov 19, 2018
hhemanth
commented
- Made changed to Gemfile add new gems and remove some gems from production env
- Add puma configs
- Added default README
- Added circleci config
adamaziz15
reviewed
Nov 19, 2018
ouranos
reviewed
Nov 20, 2018
There was a problem hiding this comment.
Looks ok so far, see minor comments.
The bin/setup might have to be updated to work out of the box (copy the application.yml and the database.yml from the sample files) and to include SKIP_CONFIGURATION=true
See https://github.com/maestrano/connector-talech/commit/0a2cdb13dccc7ce1cae9ac6cc914533172ac247e
See this section of the onboarding for the commit message format
hhemanth
commented
Nov 21, 2018
hhemanth
commented
Nov 21, 2018
ouranos
reviewed
Nov 21, 2018
alexmaestrano
approved these changes
Nov 25, 2018
ouranos
approved these changes
Dec 5, 2018
hhemanth
force-pushed
the
feature/improve-connector-framework
branch
from
363f01d
to
9e3f854
Compare
|
@hhemanth LGTM. could you squash those commits before I merge? Thanks. |
…ices - Made changed to Gemfile add new gems and remove some gems from production env - Add puma configs - Added default README - Added circleci config - Added setup file, which copies, database-sample.yml and application-sample.yml - concurrent-ruby 1.1.3 gem is causing issues (Nameerror), so locked it to 1.0.5 - Fixing typos - Fixing gem versions - Handling formatting of comments in entity.rb
hhemanth
force-pushed
the
feature/improve-connector-framework
branch
from
9e3f854
to
bf7f3e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.