This repository has been archived by the owner on Jun 2, 2019. It is now read-only.
Create the symlink inside the if #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem having it outside of the if is that the untar resource doesn't exist if maven is already installed. I justify moving it inside becasue if the symlink doesn't exist, then it is likely that $::maven_version will not be the same as $version, and will install the version specified, thus creating the new symlink.
|
Don't know why the specs don't fail with that. Fixed, thanks! |
carlossg
added a commit
that referenced
this pull request
Oct 18, 2013
Create the symlink inside the if
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem having it outside of the if is that the untar resource
doesn't exist if maven is already installed. I justify moving it inside
becasue if the symlink doesn't exist, then it is likely that
$::maven_version will not be the same as $version, and will install the
version specified, thus creating the new symlink.