-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support login via oauth #90
Comments
Hey there, great suggestion! And great that you want to work on that 🔥
|
Hey,
yeah, lets talk start of next week, when my vacation starts.
Basically, oauth provides you just with another authentication way instead
of password verification.
App authorization stays the same via jwt. The benefit ist that the User
doesnt have to create a dedicated Account with ist own Password (for
everyone without a PW Manager :) ) and you can directly Access User
information like email, name, avatar and more without additional input.
Just one click, review accessed data and confirm.
Es grüßt freundlich,
Omar Sood
Jonas Thelemann <notifications@github.com> schrieb am Mo., 7. Dez. 2020,
07:09:
… Hey there, great suggestion! And great that you want to work on that 🔥
As I don't yet know all details about OAuth, I'd suggest to have a chat on
Discord or on a short call.
The requirements that currently come to my mind are:
- for users authenticating via OAuth we need at least their email
address so that they can receive one main benefit they take from an account
creation: updates to events they attend without the organizer having to
know their email address. Would that be possible via OAuth?
- is OAuth a parallel/distinct authentication approach to the current
authentication mechanism where the json web token is given directly by the
database? Or will it separate just the endpoints so that some of the
programmatic authentication route to the backend will be shared?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#90>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIIFZ6434PYUQJE4BCN4KODSTRWSDANCNFSM4UPHKDKQ>
.
|
Here is a 🔥 example on how this can be implemented: https://youtu.be/c_-b_isI4vg?t=8884 |
To prepare this year's hacktoberfest, I researched the plan for updating the authentication scheme for maevsi:
As the sum of those changes is complex, any partly progress is highly appreciated! 🙏 Just remember to comment here when you start working on some task so that others are aware of that and can prevent duplicate parallel work. @goatfryed if you're fine with it, I'd edit your original port and add this plan to it so it's immediately visible for people checking out this issue. Are you? |
Sorry for the quite late reply. Yes i'm totally fine with your editing. Some more thoughts: What's the user id of users registered via oauth2 providers? It makes sense to use either email or OIDCs preferred username attribute, but in both cases how do we handle an existing user that registered via another provider (signup/another oauth2 provider). In a second step, we should move the providers to an own relationship and send a verifcation email, if a user wants to connect through a new provider. |
Okay, i spent half a day finding a working version of docker window. I'll start working on the postgraphile migration |
Alright, thank you! Any progress shared is totally fine, it's not required to implement the perfect solution right away in the limited Hacktoberfest timeframe 🙏 I think using the email address as identification is a good idea 🙌 |
I propose to add login via oauth providers.
I'd start with github as a first example case.
If you like the idea, you can assign the issue to me and I'll add it next week.
TODO
@nuxt/kit
'saddServerHandler
)postgraphile
service from this stackThe text was updated successfully, but these errors were encountered: