Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with ReadableStream from node@6.3.0 #6

Closed
dignifiedquire opened this issue Jul 8, 2016 · 0 comments
Closed

Incompatible with ReadableStream from node@6.3.0 #6

dignifiedquire opened this issue Jul 8, 2016 · 0 comments

Comments

@dignifiedquire
Copy link
Contributor

Since nodejs/node#7077 was merged and released in node@6.3.0 the internal buffer of a readable stream is no longer an array but a BufferList. Due to this issue tests started breaking with that release with the following error:

TypeError: Cannot read property 'length' of undefined
    at Connection.Duplexify._forward (/home/travis/build/ipfs/js-ipfs/node_modules/interface-connection/node_modules/duplexify/index.js:170:76)
    at Duplex.onreadable (/home/travis/build/ipfs/js-ipfs/node_modules/interface-connection/node_modules/duplexify/index.js:127:10)
    at emitNone (events.js:86:13)
    at Duplex.emit (events.js:185:7)
    at emitReadable_ (_stream_readable.js:433:10)
    at emitReadable (_stream_readable.js:427:7)
    at readableAddChunk (_stream_readable.js:188:13)
    at Duplex.Readable.push (_stream_readable.js:135:10)
@dignifiedquire dignifiedquire mentioned this issue Jul 8, 2016
Merged
dignifiedquire added a commit to dignifiedquire/duplexify that referenced this issue Jul 8, 2016
@dignifiedquire
fix: add compatability with node@6.3.0 streams
2977545 
fixes mafintosh#6
@dignifiedquire dignifiedquire mentioned this issue Jul 8, 2016
Closed
dignifiedquire added a commit to dignifiedquire/duplexify that referenced this issue Jul 8, 2016
@dignifiedquire
fix: add compatability with node@6.3.0 streams
acf662f 
Fixes mafintosh#6
@dignifiedquire dignifiedquire mentioned this issue Jul 8, 2016
Merged
@mcollina mcollina mentioned this issue Jul 9, 2016
Closed
@dignifiedquire dignifiedquire mentioned this issue Jul 15, 2016
Closed
@timsuchanek timsuchanek mentioned this issue Jul 18, 2016
Merged
twhtanghk added a commit to twhtanghk/imsails that referenced this issue Jul 22, 2016
@twhtanghk
update duplexify for node 6.3, see mafintosh/duplexify#6
f72a307
twhtanghk pushed a commit to twhtanghk/imagemagick-stream that referenced this issue Jul 24, 2016
update duplexify for node 6.3, see mafintosh/duplexify#6
0f7d15e
area added a commit to area/vinyl-fs that referenced this issue Oct 24, 2016
@area
Bump duplexify
b0e7230 
mafintosh/duplexify#6
area added a commit to area/js-ipfs-api that referenced this issue Oct 24, 2016
@area
Use custom vinyl-fs-browser with updated duplexify
7204af9 
New version of node in meteor breaks with old version:
mafintosh/duplexify#6
@sgarg7 sgarg7 mentioned this issue May 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dignifiedquire