-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'networkInterface' event #50
Conversation
@mafintosh any comment? |
@richardschneider can you add tests for these changes? |
@richardschneider sorry for the delay. this looks good to me. are the try catches and membership drops necessary? |
|
I was just trying do a PR for try/catch on |
@drahnieR are you seeing errors without the try/catch ? |
@mafintosh yes, this is what i got. I'm using https://github.com/watson/bonjour btw
|
Hey @mafintosh, can you merge this. I think the try-catch will help. |
@mafintosh can we get maintainer access for this package as well, similarly to chromecasts? |
Thanks for the patience (and ping @alxhotel). Releasing now |
7.2.4 |
Thanks @mafintosh ! 😄 |
I'm doing a peer-2-peer app and want to discover other peers when a new
network interface
is discovered. This PR emits a 'networkInterface' event.Also, I found some weirdness on Windows when the laptop sleeps and then wakes up. So a couple of socket calls are wrapped in a try/catch.
@mafintosh Again, thanks for this library!