Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes in node js debugging in v0.34.0 #141

Closed
yogesh-ti opened this issue Mar 31, 2023 · 4 comments · Fixed by #142
Closed

Breaking changes in node js debugging in v0.34.0 #141

yogesh-ti opened this issue Mar 31, 2023 · 4 comments · Fixed by #142

Comments

@yogesh-ti
Copy link

yogesh-ti commented Mar 31, 2023

Context

  • The following code which uses devtool to get websocket debugging URL has broken in the v0.34.0 release
    image

  • This is the error
    image

Workaround

  • This piece of code works fine upon changing back the cdp version to 0.33.0
@yogesh-ti
Copy link
Author

I went through the release notes and found the PR where changes were made but I didn't find any mention of changes required at the user's end. So I'm assuming the changes made don't work with the target devtool.Node

@mafredri
Copy link
Owner

mafredri commented Apr 3, 2023

Thanks for reporting @yogesh-ti, can you confirm if #142 fixes the issue?

@yogesh-ti
Copy link
Author

@mafredri I tried this and it worked. Thanks a lot for this fast addressal of the issue 👍

@mafredri
Copy link
Owner

mafredri commented Apr 4, 2023

You're welcome, and thanks for confirming the fix! Fix released in https://github.com/mafredri/cdp/releases/tag/v0.34.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants