Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/1837 Minion initial crawl can continue indefinitely #1846

Merged
merged 5 commits into from
Nov 11, 2018
Merged

Issue/1837 Minion initial crawl can continue indefinitely #1846

merged 5 commits into from
Nov 11, 2018

Conversation

t83714
Copy link
Contributor

@t83714 t83714 commented Nov 9, 2018 •
edited
Loading

What this PR does

Fixes #1837

Changes Summary:

  • Used the new hasMore field to test whether has more records for minions to go through
  • Adjusted relevant test cases to send the hasMore field as well (otherwise would break)
  • Make sure the test case also test the scenario that records.length > 0 but no records available to pull
  • Simplified checking progress test case logic

Checklist

  • There are unit tests to verify my changes are correct
  • I've updated CHANGES.md with what I changed.
  • I've linked this PR to an issue in ZenHub (core dev team only)

@AlexGilleran AlexGilleran self-requested a review November 11, 2018 22:54
@AlexGilleran
Copy link
Contributor

🎉

@AlexGilleran AlexGilleran merged commit d666987 into master Nov 11, 2018
@AlexGilleran AlexGilleran deleted the issue/1837 branch November 11, 2018 23:29
@magdabot magdabot restored the issue/1837 branch October 7, 2020 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexGilleran AlexGilleran AlexGilleran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t83714 @AlexGilleran