add support for non empty MAGE_BASE_PATH #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>
| @@ -11,5 +11,5 @@ spec: | |||
| - name: wget | |||
| image: busybox | |||
| command: ['wget'] | |||
| args: ['{{ include "mageai.fullname" . }}:{{ .Values.service.port }}'] | |||
| args: ['{{ include "mageai.fullname" . }}:{{ .Values.service.port }}{{ include "mageai.basePath" . }}'] | |||
There was a problem hiding this comment.
I think you need to add a / between port and basePath
There was a problem hiding this comment.
Hi @wangxiaoyou1993 I am adding it as part of the mageai.basePath definition on _helpers.tpl
|
cc: @dy46 |
wangxiaoyou1993
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Helm test is currently failing when MAGE_BASE_PATH is used. Fix helm charts to include it in the route, if defined
Tests
Manually tested with/without MAGE_BASE_PATH defined