Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xy] Updates on standalone scheduler configs #28

Merged
merged 2 commits into from
Nov 9, 2023
Merged

[xy] Updates on standalone scheduler configs #28

merged 2 commits into from
Nov 9, 2023

Conversation

wangxiaoyou1993
Copy link
Member

@wangxiaoyou1993 wangxiaoyou1993 commented Nov 9, 2023 •
edited
Loading

Summary

  • Set default value of standaloneScheduler to false. (not break current default behaviour)
  • Add instance type env var to scheduler and web server. Will update the Mage server code to get the instance type from env var if it exists

Tests

  • Test standaloneScheduler: false.
  • Test standaloneScheduler: true with 2 web servers and 2 schedulers (redis enabled: false)
  • Test standaloneScheduler: true with 2 web servers and 2 schedulers (redis enabled: true)

cc:

@wangxiaoyou1993 wangxiaoyou1993 merged commit a3427fb into master Nov 9, 2023
3 checks passed
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Nov 9, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wangxiaoyou1993