Integration tests/ fix failed tests #61

vpodorozh · 2023-12-02T14:33:49Z

Description (*)

Pull Request must contain fixes and changes to failed/error integration tests and/or functionality they cover.

Related Pull Requests

Current state:

tests total: 13311
failing: 37 ( https://github.com/vpodorozh/mageos-magento2/actions/runs/7476706132 )
tests in unclear status: ~0

Integration Tests Execution results on various Magento versions:

https://docs.google.com/spreadsheets/d/1bGJZ1PBY6HS4hyhJyWVX0SnEOcbESnew40Myo2Bkmn4/edit?usp=sharing

Issues to be Solved/Fixed:

Contribution

Pick up point that is not solved yet and you wanna work on
Solve it and create PR into vpodorozh:integration-tests/fix-tests (this PR branch)
Ping me in Mage-OS Discord and I'll review your PR asap. my discord vladyslavpodorozhnyi

…tStockTest::testProductStockStatusShouldBeUpdatedOnSchedule Zend_Db_Exception: Table "catalog_category_product_index_store0_replica" does not exist Partially reverting fix from Vinai: `Create category-product index table for store 0 (#47) This fixes a regression introduced by pull request #25

…de/Magento/CatalogInventory/Model/StockManagement.php:110 Test: dev/tests/integration/testsuite/Magento/Downloadable/Block/Sales/Order/Email/Items/Order/DownloadableTest.php

Failed due to visibility filter in whishlist collection. Products were not added to root category and not reindexed. So visibility filter ued to exclude them from wishlist items collection: app/code/Magento/Wishlist/Model/ResourceModel/Item/Collection.php:390

Include and use changed workflow to have more unitary tests executions

…zend-db#1 Error that was fixed: Unable to revert fixture: Magento/Framework/Backup/_files/trigger.php #0 /var/www/html/dev/tests/integration/testsuite/Magento/Framework/Backup/DbTest.php(42): Magento\Framework\Backup\DbTest->testBackupAndRollbackIncludesCustomTriggers() ...

Magento\Framework\Image\Adapter\InterfaceTest::testRotate with data set #4 ('/var/www/html/dev/tests/integ...st.png', 45, array(157, 35), 'IMAGEMAGICK') ImagickException: unrecognized color `srgb255,255,255' @ warning/color.c/GetColorCompliance/1064

Magento\Framework\Image\Adapter\InterfaceTest::testCreatePngFromString with data set #1 (array(5, 12), array(0, 0, 0), array(0, 20), array(255, 255, 255), 'IMAGEMAGICK') ImagickException: unable to read font `' @ error/annotate.c/RenderFreetype/1636

Magento\Dhl\Model\CarrierTest::testRequestToShip with data set #0 ('GB', 'EU', 'US') Failed asserting that two DOM documents are equal. - <SoftwareName>Magento</SoftwareName> + <SoftwareName>Mage-OS</SoftwareName>

Magento\Framework\Image\Adapter\InterfaceTest::testCreatePngFromString with data set #1 (array(5, 12), array(0, 0, 0), array(0, 20), array(255, 255, 255), 'IMAGEMAGICK') PHPUnit\Framework\Exception: Deprecated: Implicit conversion from float 11.34375 to int loses precision in /var/www/html/lib/internal/Magento/Framework/Image/Adapter/ImageMagick.php:505.

Magento\Framework\Image\Adapter\InterfaceTest::testRotate with data set #4 ('/var/www/html/dev/tests/integ...st.png', 45, array(157, 35), 'IMAGEMAGICK') ImagickException: unrecognized color `srgb255,255,255' @ warning/color.c/GetColorCompliance/1064

This reverts commit f01535b.

This reverts commit 7be2613.

Integration tests/graphql fix

…nput-over-test-directory Add optional param to run tests over specific directory only.

Update package name to mage-os

…sts/fix-tests

… resolving): error msg: 1) Magento\Catalog\Block\Adminhtml\Category\Checkboxes\TreeTest::testGetTreeJson Error: Call to a member function getConnectionName() on null /var/www/html/lib/internal/Magento/Framework/App/ResourceConnection.php:110 /var/www/html/app/code/Magento/Catalog/Model/ResourceModel/Category/Collection.php:570 ... ref: https://github.com/vpodorozh/mageos-magento2/actions/runs/7472531139/job/20334972566#step:6:39

Fix failed integration tests in \Magento\Customer

Fix failed tests: \Magento\Version\Controller\Index\IndexTest

ihor-sviziev · 2024-01-15T17:35:11Z

just checked TestModuleOverrideConfig failure https://github.com/vpodorozh/mageos-magento2/actions/runs/7476706132/job/20347768985#step:6:60

It looks like it was added in eceb5d9, and it depends on some overrides.xml file, that isn't triggered when running tests from specific folder. Do anyone know what is the overrides.xml file designed for and how to integrate it properly?

Might be related extdn/github-actions-m2#56, @damienwebdev maybe you know something about it?

ihor-sviziev · 2024-01-19T07:49:07Z

Hi @vpodorozh,
Could you pls try re-running tests on the latest version? I noticed that some failures aren't reproducing on the 2.4-develop branch, e.g. I suggest reverting some of my changes https://github.com/vpodorozh/mageos-magento2/pull/9.

…sts/fix-tests

Revert "Fix failed integration tests in \Magento\Customer"

vpodorozh · 2024-01-21T16:50:51Z

Hi @vpodorozh, Could you pls try re-running tests on the latest version? I noticed that some failures aren't reproducing on the 2.4-develop branch, e.g. I suggest reverting some of my changes vpodorozh#9.

Actually only one thing was fixed in latest 2.4-develop - related to spaces in page generation.
Just merged your revert.

And Magento have added a one more new bug - https://github.com/vpodorozh/mageos-magento2/actions/runs/7596143665/job/20689518571#step:6:34

For detailed test results on various Magento versions (Mage-OS, Magento + latest updated) - lookup here: https://docs.google.com/spreadsheets/d/1bGJZ1PBY6HS4hyhJyWVX0SnEOcbESnew40Myo2Bkmn4/edit?usp=sharing

composer.json

dev/tests/integration/testsuite/Magento/Framework/Backup/DbTest.php

Vinai

Could you please change those two small things I commented on?

UPDATE: both comments resolved

vpodorozh · 2024-01-24T17:52:42Z

Could you please change those two small things I commented on?

UPDATE: both comments resolved

Great @Vinai . I;ve also double-checked the fix from zend-db - works fine.
So we can merge this PR.

vpodorozh added 4 commits December 1, 2023 23:44

Fix \Magento\Paypal\Model\Express\CheckoutTest - dbIsolation missing

3423569

Fix failing tests with error undefined key 'product_id' from app/co…

3e710df

…de/Magento/CatalogInventory/Model/StockManagement.php:110 Test: dev/tests/integration/testsuite/Magento/Downloadable/Block/Sales/Order/Email/Items/Order/DownloadableTest.php

vpodorozh requested a review from a team as a code owner December 2, 2023 14:33

vpodorozh marked this pull request as draft December 2, 2023 14:34

vpodorozh added 5 commits December 8, 2023 20:59

Decrease test-cases - use php 8.2 only for testing purposes

0239a1c

Include and use changed workflow to have more unitary tests executions

Fix integration tests error:

f3136c9

Magento\Framework\Image\Adapter\InterfaceTest::testRotate with data set #4 ('/var/www/html/dev/tests/integ...st.png', 45, array(157, 35), 'IMAGEMAGICK') ImagickException: unrecognized color `srgb255,255,255' @ warning/color.c/GetColorCompliance/1064

Fix integration tests error:

8d29065

Magento\Framework\Image\Adapter\InterfaceTest::testCreatePngFromString with data set #1 (array(5, 12), array(0, 0, 0), array(0, 20), array(255, 255, 255), 'IMAGEMAGICK') ImagickException: unable to read font `' @ error/annotate.c/RenderFreetype/1636

Fix integration tests error:

ba1b153

Magento\Dhl\Model\CarrierTest::testRequestToShip with data set #0 ('GB', 'EU', 'US') Failed asserting that two DOM documents are equal. - <SoftwareName>Magento</SoftwareName> + <SoftwareName>Mage-OS</SoftwareName>

vpodorozh marked this pull request as ready for review December 8, 2023 22:41

vpodorozh marked this pull request as draft December 8, 2023 22:42

vpodorozh mentioned this pull request Dec 8, 2023

Fix integration tests mage-os/mageos-magento-zend-db#1

Merged

vpodorozh and others added 9 commits December 9, 2023 00:13

Merge branch 'adamzero1:2.4-develop' into integration-tests/fix-tests

6088684

Fix integration tests error:

c2855ed

Magento\Framework\Image\Adapter\InterfaceTest::testRotate with data set #4 ('/var/www/html/dev/tests/integ...st.png', 45, array(157, 35), 'IMAGEMAGICK') ImagickException: unrecognized color `srgb255,255,255' @ warning/color.c/GetColorCompliance/1064

Revert "feat(catalog): faster category product count (#25)"

8ec5427

This reverts commit f01535b.

Revert "Create category-product index table for store 0 (#47)"

522934d

This reverts commit 7be2613.

Merge pull request #5 from vpodorozh/integration-tests/graphql-fix

7e29915

Integration tests/graphql fix

Add optional param to run tests over specific directory only.

a16c21e

Merge pull request #6 from vpodorozh/integration-tests/add-optional-i…

062f33c

…nput-over-test-directory Add optional param to run tests over specific directory only.

novikor approved these changes Dec 29, 2023

View reviewed changes

ihor-sviziev and others added 6 commits January 10, 2024 10:45

Fix failed tests: \Magento\Version\Controller\Index\IndexTest

e5aafa2

Update package name to mage-os

Merge remote-tracking branch 'mageos/2.4-develop' into integration-te…

5b877e0

…sts/fix-tests

Fix failed integration tests in \Magento\Customer

302e339

Merge pull request #8 from ihor-sviziev/patch-2

5ae3bd9

Fix failed integration tests in \Magento\Customer

Merge pull request #7 from ihor-sviziev/patch-1

900aa2d

Fix failed tests: \Magento\Version\Controller\Index\IndexTest

Revert "Fix failed integration tests in \Magento\Customer"

edc226e

vpodorozh added 2 commits January 20, 2024 17:25

Merge remote-tracking branch 'mageos/2.4-develop' into integration-te…

67abeb0

…sts/fix-tests

Merge pull request #9 from ihor-sviziev/revert-8-patch-2

ea8e2a9

Revert "Fix failed integration tests in \Magento\Customer"

Update full-integration-tests.yaml

e57044a

vpodorozh marked this pull request as ready for review January 24, 2024 09:28

Vinai reviewed Jan 24, 2024

View reviewed changes

composer.json Show resolved Hide resolved

Vinai reviewed Jan 24, 2024

View reviewed changes

dev/tests/integration/testsuite/Magento/Framework/Backup/DbTest.php Show resolved Hide resolved

Vinai requested changes Jan 24, 2024

View reviewed changes

ihor-sviziev mentioned this pull request Jan 25, 2024

Integration tests workflow improvements mage-os/github-actions#218

Merged

13 tasks

Vinai approved these changes Jan 25, 2024

View reviewed changes

Vinai merged commit fb84973 into mage-os:2.4-develop Jan 25, 2024
4 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integration tests/ fix failed tests #61

Integration tests/ fix failed tests #61

vpodorozh commented Dec 2, 2023 •

edited

Loading

ihor-sviziev commented Jan 15, 2024 •

edited

Loading

ihor-sviziev commented Jan 19, 2024

vpodorozh commented Jan 21, 2024 •

edited

Loading

Vinai left a comment •

edited

Loading

vpodorozh commented Jan 24, 2024

Integration tests/ fix failed tests #61

Integration tests/ fix failed tests #61

Conversation

vpodorozh commented Dec 2, 2023 • edited Loading

Description (*)

Related Pull Requests

Current state:

Integration Tests Execution results on various Magento versions:

Issues to be Solved/Fixed:

Contribution

ihor-sviziev commented Jan 15, 2024 • edited Loading

ihor-sviziev commented Jan 19, 2024

vpodorozh commented Jan 21, 2024 • edited Loading

Vinai left a comment • edited Loading

Choose a reason for hiding this comment

vpodorozh commented Jan 24, 2024

vpodorozh commented Dec 2, 2023 •

edited

Loading

ihor-sviziev commented Jan 15, 2024 •

edited

Loading

vpodorozh commented Jan 21, 2024 •

edited

Loading

Vinai left a comment •

edited

Loading