Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCL_recv rework based on closed Magento 2 PR #62

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

toonvd
Copy link

@toonvd toonvd commented Dec 2, 2023

Description

This PR is a rework of the Magento VCL (the vcl_recv part) PR found here:
https://github.com/magento/magento2/pull/36796/files

I left out 2 controversial changes:

  • Removing the pass of /customer and /checkout
    Main reason for this is that, as a hoster (and support on Varnish issues), I see a lot of extensions that accidently remove
    cache disables. Without this part of the VCL, the result could be a disaster for merchants.
  • Removing caching of authenticated GraphQL requests
    Though I understand the reasoning behind this (preventing cache variations), the same technique is used in the frontend.
    I have seen this work perfectly for one of our clients, so I am hesitant to remove something that seemed to be working

PRs for other subroutines will follow (probably weekly)

All credits go to @peterjaap and @ThijsFeryn, I am simpling slicing this up and removing controversial parts to get early approval.

Related Pull Requests

https://github.com/magento/magento2/pull/36796/files

Manual testing scenarios

  • Load the new VCL
  • Test if compression still works
  • Test if restarts don't loop anymore
  • Test purges without headers

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@toonvd toonvd requested a review from a team as a code owner December 2, 2023 19:34
@peterjaap
Copy link
Contributor

Thanks @toonvd, it's still on my todo list to make that Magento PR better, but time & priorities, so I'm excited to see you picking this up for MageOS! :)

@ThijsFeryn
Copy link

Looks good to me, thanks for the effort @toonvd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants