Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve vcl hash #69

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

toonvd
Copy link

@toonvd toonvd commented Dec 9, 2023

Description

This PR is a rework of the Magento VCL (the vcl_hash part) PR found here:
https://github.com/magento/magento2/pull/36796/files

It is mildly adapted since I decided to not remove the hashing on the graphql part.

PRs for other subroutines will follow (probably weekly)

All credits go to @peterjaap and @ThijsFeryn, I am simpling slicing this up and removing controversial parts to get early approval.

Related Pull Requests

#62

Manual testing scenarios

  • Load the new VCL
  • Test if Graphql behaves the same way when authenticated and not authenticated (storeswitch / currencyswitch)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@toonvd toonvd requested a review from a team as a code owner December 9, 2023 20:42
@toonvd
Copy link
Author

toonvd commented Dec 9, 2023

@danslo I haven't worked with Magento graphQL much, would you be willing to also test / doublecheck?
The changes aren't extreme but I don't want to risk anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant