Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save test report in a dedicated file - Feature/5 #9

Merged
merged 22 commits into from
Apr 25, 2017
Merged

Save test report in a dedicated file - Feature/5 #9

merged 22 commits into from
Apr 25, 2017

Conversation

mageddo
Copy link
Owner

@mageddo mageddo commented Apr 21, 2017 •
edited
Loading

Features

gulucas and others added 19 commits December 30, 2016 17:02
Save test report in a dedicated file (different than the one used for…
d20a098 
… standard output)
Use an absolute filepath for test files in the report (fix a problem …
bf8f661 
…where Sonar can't find the file)
@mageddo
#5 adding tests
40e08e7
@mageddo
#5 completing test
a442ca0
@mageddo
#5 new tests
f5e506e
@mageddo
#5 getting options
ad3ed16
@mageddo
#5 setting outputfile
fde44e3
@mageddo
Merge pull request #7 from guilhem88/outputfile-env-var
43180d8 
Outputfile env var
@mageddo
Merge branch 'develop' of https://github.com/mageddo/mocha-sonar-gene…
c604f8e 
…ric-test-coverage into develop
@mageddo
#5 solving merge
b82482e
@mageddo
#5 adding test case
c502778
@mageddo
#5 fullpath test case
b4dd34f
@mageddo
#5 fixing test task
11e3742
@mageddo
#5 documenting
bcb7ada
@mageddo
#5 stdout test
5109c3e
@mageddo
#5 refactoring packages
90c8997
@mageddo
#5 otimizing
fd5fba0
@mageddo
#5 increase readme
23a0289
@mageddo
#5 fixing json
ed478b0
@mageddo
Copy link
Owner Author

mageddo commented Apr 21, 2017 •
edited
Loading

Hey guys, this is my release candidate with your changes and my changes for standardization, to keep compatibility with your version I kept two options:

  • Set report file by env
  • New option to use fullpath file

I will wait for one week before merge it, if you guys have any suggestions please let me know.

Many Thanks @guilhem88 @topaxi

@mageddo mageddo mentioned this pull request Apr 21, 2017
Closed
guilhem-lk
guilhem-lk suggested changes Apr 24, 2017
View reviewed changes
Copy link

@guilhem-lk guilhem-lk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This is working fine on my project. If you prefer to use outputFile variable instead of an env var, you can delete mocha_sonar_generic_test_coverage_outputfile.

@mageddo
Copy link
Owner Author

mageddo commented Apr 24, 2017 •
edited
Loading

Ok, Let's wait for @topaxi, then I will merge and release 0.0.2 NPM version

@topaxi
Copy link

topaxi commented Apr 24, 2017

I won't be able to test this, as I'm in the middle of a sonar upgrade and fully booked the rest of the week :)

@mageddo
Copy link
Owner Author

mageddo commented Apr 24, 2017

Ok @topaxi, let's generate a release of this, then if you a interested to test it let we know.

Thank you guys

@mageddo mageddo added this to the 0.0.2 milestone Apr 24, 2017
@mageddo
Copy link
Owner Author

mageddo commented Apr 25, 2017

0.0.2 (with env support) and 0.0.3 removing env support was released.

Thank you for the new features, and you are welcome to contribute with more.

@mageddo mageddo closed this Apr 25, 2017
@mageddo mageddo reopened this Apr 25, 2017
@mageddo mageddo merged commit 1796cef into master Apr 25, 2017
@mageddo mageddo deleted the feature/5 branch April 25, 2017 00:57
@mageddo mageddo modified the milestones: 0.0.3, 0.0.2 Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhem-lk guilhem-lk guilhem-lk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mageddo @topaxi @guilhem-lk