Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a DAMAGED_COMBAT_ALL_BATCH event #10773

Closed
xenohedron opened this issue Aug 8, 2023 · 2 comments · Fixed by #11995
Closed

Need a DAMAGED_COMBAT_ALL_BATCH event #10773

xenohedron opened this issue Aug 8, 2023 · 2 comments · Fixed by #11995
Labels
bug Bugs and errors refactoring Developers topics about code and programming

Comments

@xenohedron
Copy link
Contributor

As discovered in #10763 and #10767. There are subtle bugs with the current implementation of separate GameEvents for DAMAGED_PLAYER_BATCH and DAMAGED_PERMANENT_BATCH when an ability needs to trigger on all combat damage dealt and use the amount of damage for an effect. If a creature with trample deals damage simultaneously to permanent and player, there is no way for the engine to capture that correctly right now (unless I'm missing something).

Affected abilities:

  • DealsCombatDamageTriggeredAbility
  • DealsCombatDamageEquippedTriggeredAbility

Affected cards:

  • [[Sword of Hours]]
  • [[Aisha of Sparks and Smoke]]
@xenohedron xenohedron added bug Bugs and errors refactoring Developers topics about code and programming labels Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Sword of Hours - (Gatherer) (Scryfall) (EDHREC)

{2}
Artifact — Equipment
Whenever equipped creature attacks, put a +1/+1 counter on it.
Whenever equipped creature deals combat damage, roll a d12. If the result is greater than the damage dealt or the result is 12, double the number of +1/+1 counters on that creature.
Equip {2} ({2}: Attach to target creature you control. Equip only as a sorcery.)

Aisha of Sparks and Smoke - (Gatherer) (Scryfall) (EDHREC)

{1}{R}{R}
Legendary Creature — Human Warrior
4/2
Prowess (Whenever you cast a noncreature spell, this creature gets +1/+1 until end of turn.)
{R/W}: Aisha of Sparks and Smoke gains first strike until end of turn.
Whenever Aisha deals combat damage, you may cast a sorcery spell from your hand with mana value less than or equal to that damage without paying its mana cost.

@xenohedron
Copy link
Contributor Author

see related #11985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs and errors refactoring Developers topics about code and programming
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant