Improve DealsCombatDamageEquippedTriggeredAbility #10767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You don't need the "amount < 1" check since that was due to the summing operation returning 0 if the filters weren't met. Aside from that yours looks good. |
|
I'm pretty sure that check is still important; I didn't change the code that filters and sums. |
|
Right, misread that/was still thinking of mine where I didn't use the batch events. Should the other ability also be using batch events? I guess right now there aren't any cards using the "amount" output from either of these triggers aside from the Sword but the TODO should apply to the original ability as well, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10763 and adds test. This still isn't perfect as events that care about the saved damage value won't get the full damage in case of trampling over, but only one card seems like it would be affected.
@ssk97 sorry for duplicate effort- anything I should adjust with this?