Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High Alert #11179

Closed
heloirf opened this issue Sep 19, 2023 · 2 comments · Fixed by #11180
Closed

High Alert #11179

heloirf opened this issue Sep 19, 2023 · 2 comments · Fixed by #11180
Assignees
Labels
bug Bugs and errors

Comments

@heloirf
Copy link

heloirf commented Sep 19, 2023

"High Alert" is affecting opponents' creatures.

High Alert
{1}{W}{U}
Enchantment

Each creature you control assigns combat damage equal to its toughness rather than its power.
Creatures you control can attack as though they didn’t have defender.
{2}{W}{U}: Untap target creature.

@xenohedron xenohedron self-assigned this Sep 19, 2023
@xenohedron
Copy link
Contributor

Damn, I thought it was just a simple typo in the new StaticFilter (getPlayerPredicate() should be getControllerPredicate()) but it's a deeper problem. @xanderhall 's rework in #11068 probably should have added a few more test cases (well, ideally some tests would have existed beforehand). The inner combat method useToughnessForDamage calls filter.match with two arguments instead of four, ignoring controller predicates in the filter.

@xenohedron xenohedron added the bug Bugs and errors label Sep 19, 2023
@xenohedron
Copy link
Contributor

I think I'm going to split off another class CombatDamageByToughnessControlledEffect to handle the filter copy logic and add the ControllerIdPredicate like the old effect did, and add a warning to each about predicates being ignored.

xenohedron added a commit to xenohedron/mage that referenced this issue Sep 19, 2023
new CombatDamageByToughnessControlledEffect
add tests
fix magefree#11179
xenohedron added a commit that referenced this issue Sep 19, 2023
new CombatDamageByToughnessControlledEffect
add tests
fix #11179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs and errors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants