New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if source object is still the same as an ability was put on the stack. #4893
Comments
Each time a permanent enters the battlefield it is assigned a unique id. Spells and abilities target permanents via this id and therefor fizzle if the permanent is blinked. |
Blink (zone change) will cause NEW and clean permanent to enter battlefield. The old one target will be illegal and spell resolves with nothing. The new permanent must be clear from all added effects/abilities and must have new ID. https://mtg.gamepedia.com/Flicker
|
I'm not talking about targeted abilties. Target handling does handle this correctly (at least if TargetHandler are used). I'm talking about effects that are named xxxSourceEffect.java. We have to check for this effects if the related source is the same like done in the Wall of Deceit effect. |
You have to check if the permanent didn't blink like you did for Wall of Deceit for all xxxSourceEffect. |
This is something that's been changed in some places (like The Scarab God death trigger) but clearly not everywhere. There's definitely a framework in place for it, since you can get the zone change counter from the source, so it's just a matter of making sure it's always done. |
I'm consulted with mtg judges and they confirmed -- "source effects" without targets like |
This is still bugged, for sure. Cloudshifting a Drudge Sentinel with an activation on the stack causes it to return and gain indestructible. |
I recently fixed a bug of Wall of Deceit. The "Turn face down" ability did not work.
In the fix I added some logic to prevent, that the effect works, if the Wall was Blinked (e.g. with Momentary Blink) between adding the ability to stack and the resolving of the ability.
I guess that way to handle it is correct, if the ability on the stack is related to a previous permanent onto the battlefield.
Also some confirmation for that rule interpretation from rule gurus is appreciated. I 'm pretty sure the ability on the stack does simply nothing (even not fizzle because targets are not involved), if the object the ability was created from is no longer on the battlefield.
But by checking it this way, I realized that there are a ton of abilities related to source (without using a target) that probably need a similar handling.
Take as an example Drudge Sentinel. It has the following ability:
// {3}: Tap Drudge Sentinel. It gains indestructible until end of turn.
If you activate its Tap/get indestructible ability and the Sentinel was blinked before resolution of the ability. The ability should do nothing but currently it resolves and taps the Sentinel and adds indestructible to it.
Am I right, that this kind of abilities are not handled correctly currently?
The text was updated successfully, but these errors were encountered: