Change target of TargetOpponent target does not work correctly

[RemkoA]

Hi,
I have had an issue with a misdirected Hymn to Tourach twice now. The program just doesnt let me do anything anymore as is asks for selecting an opponent. Clicking on the opponent doesnt work and clicking anywhere else doesnt do much either.

[RemkoA]

Update: It works properly on abrupt decay.

[emerald000]

Hymn to Tourach was implemented with TargetOpponent instead of TargetPlayer
Fixed with d0b592a.

[LevelX2]

The problem is that if a player has to change the target of a spell controlled by another player with targets like "opponent" or "opponent creatures" are not handled correctly. There is yet no clear distiction between the player that selects the target and the controller of the spell, the targets are choosen for.
That leads to targets that are valid while playerA selects it (e.g. opponent of playerA) but are getting invalid as soon as the target is checked with playerB, the spell controller.

So there are some changes needed to targets and target handling to fix the cause of this problem.

A new example for the problem is to use Misdirection on a Rakshasa's Secret.

[RemkoA]

Yes, or Duress.
Another complicated one is to let my opponent target their own True-Name
Nemesis with their own spell using Misdirection. This should in theory be
possible but I can imagine this gives some problems writing the program.
The situation did not occur to me yet, but it is probably not entirely
handled correctly.

2014-09-23 16:41 GMT+02:00 LevelX2 notifications@github.com:

Reopened #574 #574.

—
Reply to this email directly or view it on GitHub
#574 (comment).

[emerald000]

Just to make sure, here's the correct way to change targets:

114.6a If an effect allows a player to "change the target(s)" of a spell or ability, each target can be changed only to another legal target. If a target can't be changed to another legal target, the original target is unchanged, even if the original target is itself illegal by then. If all the targets aren't changed to other legal targets, none of them are changed.

114.6b If an effect allows a player to "change a target" of a spell or ability, the process described in rule 114.6a is followed, except that only one of those targets may be changed (rather than all of them or none of them).

114.6c If an effect allows a player to "change any targets" of a spell or ability, the process described in rule 114.6a is followed, except that any number of those targets may be changed (rather than all of them or none of them).

114.6d If an effect allows a player to "choose new targets" for a spell or ability, the player may leave any number of the targets unchanged, even if those targets would be illegal. If the player chooses to change some or all of the targets, the new targets must be legal and must not cause any unchanged targets to become illegal.

114.6e When changing targets or choosing new targets for a spell or ability, only the final set of targets is evaluated to determine whether the change is legal.

[RemkoA]

Oh, didnt check how you changed it. This was clearly an issue with Hymn to
Tourach.

2014-09-23 17:15 GMT+02:00 emerald000 notifications@github.com:

Just to make sure, here's the correct way to change targets:

114.6a If an effect allows a player to "change the target(s)" of a spell
or ability, each target can be changed only to another legal target. If a
target can't be changed to another legal target, the original target is
unchanged, even if the original target is itself illegal by then. If all
the targets aren't changed to other legal targets, none of them are changed.

114.6b If an effect allows a player to "change a target" of a spell or
ability, the process described in rule 114.6a is followed, except that only
one of those targets may be changed (rather than all of them or none of
them).

114.6c If an effect allows a player to "change any targets" of a spell or
ability, the process described in rule 114.6a is followed, except that any
number of those targets may be changed (rather than all of them or none of
them).

114.6d If an effect allows a player to "choose new targets" for a spell or
ability, the player may leave any number of the targets unchanged, even if
those targets would be illegal. If the player chooses to change some or all
of the targets, the new targets must be legal and must not cause any
unchanged targets to become illegal.

114.6e When changing targets or choosing new targets for a spell or
ability, only the final set of targets is evaluated to determine whether
the change is legal.

—
Reply to this email directly or view it on GitHub
#574 (comment).

[msmorgan]

I think the current test case is incorrect. For the test case to succeed, playerB would need to successfully change the target of playerA's Rakshasa's Secret to its controller, playerA. According to rule 114.6a, this should not be possible, since the spell requires the target to be an opponent. As playerA is not a valid target, the target should remain unchanged. The spell should resolve and playerB should discard two cards. That's what happens when the test is run, but it's counted as a failure because it asserts that playerB did not discard.