-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tokens must be reworked (missing tokens from old sets, broken images) #6955
Comments
@timhae You mentioned interest in this project, if you'd still like it. |
@PurpleCrowbar See which of these you are closing with your PRs |
There is special test |
How can I test which Tokens I am missing? (is there a way to generate a list of missing token images?) In the image downloader I can see I am missing 32 card images and 238 token images.... I got most of the missing card images here using the clipboard option: #9249 (comment) but for tokens option 8 Copy and Paste Image URLs does not seem to apply to tokens... |
Here is how I figured out which ones are missing (on a linux operating system): cd ~/xmage/xmage/mage-client/
unzip ./plugins/images/TOK.zip -d ./TOK
wget https://raw.githubusercontent.com/magefree/mage/master/Mage.Client/src/main/resources/card-pictures-tok.txt
sed -i 's/^[^:]*://' card-pictures-tok.txt
sed -i 's/|/\//' card-pictures-tok.txt
sed -i 's/|.*/.full.jpg/' card-pictures-tok.txt nano tokens.sh #!/bin/bash
echo "" > missing-tokens.txt
while IFS="" read -r p || [ -n "$p" ]
do
if ! [ -e "TOK/$p" ]
then
printf '%s\n' "$p"
printf '%s\n' "\"TOK/$p\", \"\"" >> missing-tokens.txt
fi
done < card-pictures-tok.txt chmod +x tokens.sh
./tokens.sh Now I just have to manually download the missing files reported by the script, and then recompress and replace the TOK.zip archive It appears the 238 missing token images is False, a lot of the reportedly missing tokens seem to not actually be real cards that are listed in card-pictures-tok.txt, I did however find some missing tokens, I have listed them below:
|
- removed outdated code; - updated logic to choose a set code for a tokens in different use cases (related to magefree#10150); - added many tests for client and server token's data (related to magefree#10139); - prepare for tokens database (related magefree#6955);
Not actual anymore |
Now that pull #6190 for card images has been merged, it should be safer / easier to clean up token images in similar ways. In particular, the following issues:
test_checkMissingTokenData
for more bugs/errors)Documenting that 1) a lot of tokens are linking incorrectly or are missing, and 2) if a token can't be found for a given art, we should fall back to any other art of it we do have, to minimize the number of times we show art-less tokens.
The text was updated successfully, but these errors were encountered: