Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix The Great Henge cost reduction #11165

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

Susucre
Copy link
Contributor

@Susucre Susucre commented Sep 16, 2023

The cost reduction was not correct if the player casting the spell was not The Great Henge's owner.

For instance with cards like Gonti, Lord of Luxury or Hostage Taker, it might not be the owner's that is casting it. In such case, the cost reduction was incorrect.

@Susucre Susucre changed the title fix The Great Henge cost reduction Fix The Great Henge cost reduction Sep 16, 2023
@github-actions
Copy link

The Great Henge - (Gatherer) (Scryfall) (EDHREC)

{7}{G}{G}
Legendary Artifact
This spell costs {X} less to cast, where X is the greatest power among creatures you control.
{T}: Add {G}{G}. You gain 2 life.
Whenever a nontoken creature enters the battlefield under your control, put a +1/+1 counter on it and draw a card.

Gonti, Lord of Luxury - (Gatherer) (Scryfall) (EDHREC)

{2}{B}{B}
Legendary Creature — Aetherborn Rogue
2/3
Deathtouch
When Gonti, Lord of Luxury enters the battlefield, look at the top four cards of target opponent's library, exile one of them face down, then put the rest on the bottom of that library in a random order. You may cast that card for as long as it remains exiled, and mana of any type can be spent to cast it.

Hostage Taker - (Gatherer) (Scryfall) (EDHREC)

{2}{U}{B}
Creature — Human Pirate
2/3
When Hostage Taker enters the battlefield, exile another target creature or artifact until Hostage Taker leaves the battlefield. You may cast that card for as long as it remains exiled, and mana of any type can be spent to cast it.

@Susucre
Copy link
Contributor Author

Susucre commented Sep 16, 2023

Well there might be more cards with the same issue. I'll refactor some of them in a common effect.

@Susucre Susucre marked this pull request as draft September 16, 2023 17:09
@Susucre
Copy link
Contributor Author

Susucre commented Sep 16, 2023

Ok, this fix only Great Henge and can be merged, but there is almost no cost reduction / cost increase / permission that is working right when it does count/check something for the controller.
I'll make an issue for some of the bugged ones.

@xenohedron xenohedron merged commit 6b7c052 into magefree:master Sep 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants