Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 2s protection timer during draft #11188

Merged
merged 3 commits into from
Sep 24, 2023

Conversation

Susucre
Copy link
Contributor

@Susucre Susucre commented Sep 21, 2023

The draft panel can be a little hasty to react to mouse events when boosters just appeared.
This PR adds a 2s grace time for each pick, after booster have been rendered, to prevent mispicking cards. As it happens from time to time, especially with players not that used to the drafting on xmage. That leads to feel bad moments missing picks (and not even knowning what was there unless looking at logs).

User feedback around that protection timer could be improved from there, either with the protection timer being shown somewhere (and replaced with a confirm pick button maybe?), alert (popup?) that the pick was prevented due to it being too fast since booster was drawn first, and/or change the color for the selected card from orange (during protection time), to green (after protection time is over).

@xenohedron
Copy link
Contributor

Sounds like a good improvement. Can you describe what manual testing you've done to confirm functionality?

@Susucre
Copy link
Contributor Author

Susucre commented Sep 23, 2023

I have done drafts with 1 and 2 human players and the rest bots.

Attempted at multiple different picks to pick from two consecutive booster fast. Protection was there to only select if the booster did not show up for 2s.
Also waited for autopick, and 2s protection delay is there in the next pick.

Also made sure I did not break the select functionality through single click. And no change was noticeable (none was expected).

@xenohedron xenohedron merged commit a58cac2 into magefree:master Sep 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants