New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync part of cards zcc properly #12186
base: master
Are you sure you want to change the base?
Conversation
@@ -438,7 +438,7 @@ private static boolean maybeRemoveFromSourceZone(ZoneChangeInfo info, Game game, | |||
if (event.getToZone() == Zone.BATTLEFIELD && event.getTarget() != null) { | |||
event.getTarget().updateZoneChangeCounter(game, event); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw for that TODO: wtf
comment in PermanentCard, this is where that would be called.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Permanent’s zcc is static and can’t be changed (only synced on first usage/init/put). If it changed somehow then it can be an error or wrong code usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but when the permanent is put onto the battlefield, its card's zcc gets updated, and the permanent stores that updated zcc.
I don't think a permanent's zcc should move after that.
|
For MDFC / Split / Others. Started from argumenting in #12184
It would make a LOT of sense to keep part of cards zcc sync.
All tests are working here. MDFC are some of the cards with a lot of coverage. There is no issue ensuring the main card and the parts are in zcc sync.
Please @JayDi85, give me an example of behavior this would break. I can add unit tests if you're not convinced.
Fix #10478