New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[don't merge] [NCC] Implement Henzie "Toolbox" Torre #12188
base: master
Are you sure you want to change the base?
Conversation
I haven't tried playing with him a bunch, I'll do that a bit and report back if I see anything weird beyond what I've mentioned above. |
See some problems with wrong abilities usage, will review later with details. |
Some thoughts:
I'll write up tests for these later. |
Phyrexian Tower - (Gatherer) (Scryfall) (EDHREC)
|
Another thought: check if opponents who can play your cards can use blitz cost. If so, we might have to rethink how alternate casting costs are given to spells... |
|
2ef3d97
to
5536881
Compare
Sorry about that - I did a rebase and accidentally pulled instead of force-pushing. Should be better now. |
- Give Blitz to spells on the stack, in addition to the cards. This allows creature to come in with proper haste and delayed trigger. - Fixed cost reduction test (this was always working - the test just didn't have enough mana to cast) - `Commander` objects now load abilities from the current game when a player is presented options for abilities to activate. This was not previously the case, so any `SpellAbility` added to a commander in the command zone (such as with Henzie) would not be playable by players. - Added some more tests
5536881
to
c572a9e
Compare
I also ended up removing the changes to the rad counter test I inadvertently pushed |
Building off the work done in #9463
The biggest issue that I've run into so far is that
Commander
objects only seem to only keep track of activated abilities that were printed on the card - so any activated abilities (such as blitz) added to the commander during the game aren't respected. I've updated this, but I'm not confident in it. Let me know your opinions.Currently, the biggest blocker is casting other players' cards - but there is a comment in the code saying that this depends on #9521 which is not currently merged. Does anyone know the status of this?