Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps #7128

Closed
wants to merge 2 commits into from
Closed

Update deps #7128

wants to merge 2 commits into from

Conversation

allentiak
Copy link
Contributor

No description provided.

@allentiak
Update deps (except JSON deps)
6c411d2 
The API from the JSON lib changed between the current version (1.1.1) and the new version (3.1.1)
@allentiak
Update JSON deps, package names, classes and method calls
6b14d43
@allentiak allentiak mentioned this pull request Oct 11, 2020
Merged
@JayDi85
Copy link
Member

JayDi85 commented Oct 11, 2020

Do not update deps that's way. It can be broken. Example:
shot_201011_084012

Also there are dependebot PRs already.

@JayDi85 JayDi85 closed this Oct 11, 2020
@allentiak
Copy link
Contributor Author

allentiak commented Oct 11, 2020 •
edited

@JayDi85 I have just reverted the H2 dep update, and have moved the warning closer to the version number (I hadn't seen it in the first place.)

What about the other, non-H2 deps? (For instance, dependabot won't be able to update the JSON deps, since they changed their API and require a small code change.)

@allentiak
Copy link
Contributor Author

allentiak commented Oct 11, 2020 •
edited

@JayDi85 Plus, I think the specific problem you mention does not apply here, since the DB is rebuilt from scratch regularly.

@allentiak
Copy link
Contributor Author

As I have changed the code, I will open a new PR and move my new comments there.

@allentiak allentiak mentioned this pull request Oct 11, 2020
Closed
@allentiak
Copy link
Contributor Author

@JayDi85 Please see #7131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@allentiak @JayDi85