Skip to content
This repository has been archived by the owner on Apr 29, 2019. It is now read-only.

Magento 2.0.7 Import Products sets default behaviour as append, need add_update #54

Closed
piotrekkaminski opened this issue Nov 6, 2017 · 6 comments
Assignees
Projects
Milestone

Comments

@piotrekkaminski
Copy link
Contributor

From @Taral-Patoliya on August 17, 2016 7:29

I am importing the products using array instead of csv, And using FireGento_FastSimpleImport2 Module to pass the product array to the import model. I have set the behavior of import to be 'add_append', but getBehavior() method in the Magento/ImportExport/Model/Import/Entity/AbstractEntity class checks the condition and sets behavior as 'append'. I need to know why the product import does not allow add_update behavior? i believe that the append is responsible for multiple stock item entries in the table cataloginventory_stock_item for same item, which generates error in the catalog product grid.

Copied from original issue: magento/magento2#6193

@piotrekkaminski
Copy link
Contributor Author

From @shiftedreality on September 9, 2016 7:9

Hi @Taral-Patoliya

Looks like an error to me.
Created internal ticket MAGETWO-58210 to investigate and fix.
Thank you for reporting.

@piotrekkaminski
Copy link
Contributor Author

From @diglin on September 19, 2017 12:36

Also into Magento 2.1.7 and Magento 2.2

Looks like an issue into the method \Magento\ImportExport\Model\Import\Entity\AbstractEntity::getBehavior which doesn't allow other behavior as append, replace and delete. Using custom or add_update is not allowed and fallback to append which is the default behavior

Need a PR ?

Patch in attachment

patch_behavior_add_update_import.patch.txt

@piotrekkaminski
Copy link
Contributor Author

From @diglin on September 19, 2017 13:34

Why G1 Failed label ?

-> found myself the answer => https://github.com/magento/magento2/wiki/Magento-Issue-Gates

@piotrekkaminski
Copy link
Contributor Author

From @magento-engcom-team on September 22, 2017 9:6

Hi @diglin
PR would be always helpful. If you wish to work on that please provide clear testing scenarios and link to this issue.

Thank you for collaboration

@dmanners dmanners added this to To Do in Phase 2 Dec 20, 2017
@dmanners dmanners added this to the Phase 2 milestone Feb 13, 2018
magento-engcom-team pushed a commit that referenced this issue Aug 27, 2018
Merge 2.3-develop to EPAM-PR-2
@dmanners dmanners moved this from To Do to In progress in Phase 2 Oct 26, 2018
@dmanners dmanners moved this from In progress to Verification in Phase 2 Oct 26, 2018
@dmanners
Copy link
Contributor

dmanners commented Nov 9, 2018

Thanks for this PR. This has now been merged into 2.3-develop.

@dmanners dmanners closed this as completed Nov 9, 2018
@dmanners dmanners moved this from Verification to Done in Phase 2 Nov 9, 2018
@mflasquin
Copy link

Hi, can you tell me when this PR will be available on Magento 2.3.0 stable branch ?
Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Phase 2
  
Done
Development

No branches or pull requests

4 participants