Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement create account for Venia (MVP) #250

Closed
3 tasks
ericerway opened this issue Aug 23, 2018 · 1 comment
Closed
3 tasks

Implement create account for Venia (MVP) #250

ericerway opened this issue Aug 23, 2018 · 1 comment

Comments

@ericerway
Copy link

ericerway commented Aug 23, 2018

This issue is for the following packages:

[X] venia-concept
[ ] pwa-buildpack
[ ] peregrine
[ ] pwa-module
[ ] pwa-devdocs

Description

As a shopper, I want to create an account with Venia so that I can access previous orders, subscriptions and other features.

  • First Name (required)
  • Last Name (required)
  • Subscription? (default: no)
  • Email (required)
  • Password (required)
  • Confirm Password (required)

Assumptions

  • Basic error messaging OK as placeholder until Account epic story complete
  • Edits and validations (future)
  • Password strength (future)
  • Transfer of anonymous cart (merge) to new account
  • Utilize REST API for account where GraphQL not available

Tasks

  • Discovery to store and verify email/password from API
  • Display basic error messaging (from API)
  • Testing and documentation (as appropriate)
@ericerway ericerway changed the title Implement basic login for Venia (MVP) Implement create account for Venia (MVP) Aug 23, 2018
@ericerway ericerway added the for-grooming Candidate for team grooming on Friday with Community. label Aug 23, 2018
@ericerway
Copy link
Author

Kamino cloned this issue to magento-research/pwa-studio

@ericerway ericerway removed the for-grooming Candidate for team grooming on Friday with Community. label Sep 6, 2018
zetlen pushed a commit that referenced this issue Oct 3, 2018
* create generic input component

* ignore storybook-dist in eslint

* create login component, action and reducer catch

* Hook login form to utilize and store token

* Add navigation animation and user icon

* add auth to REST requests

* Add user icon

* add auth header login_token to graphql queries

* Change animation, add user to store

* Move user logic into separate action/reducer

* Add token to auth headers when token is available (rest)

* Style sign in form, fix user reducer

- Style form to match mockup
- Fix misimport of user reducer

* Rename log in -> sign in. Wire up sign in form.

- Rename log in to sign in to match mockups
- Style error messages in sign in form

* Change login to signin

* Add proptypes, clean up css

* Prettier pass

* write test for signIn and input, small style and prop fixes

* lint and prettier pass

* reword a c ouple tests

* fix dependency issue and clean up navigation component

* Add redux actions to create account and transfer guest cart to user's account

* add form, navheader and create account components, update styles

* Refactor createAccount, handle transferring cart

- Transferring cart to a newly created customer account created an
issue where a guest cart could not be made. getCartDetails now checks if
a user is signed in.

* add debounce email check

* add error display and checkbox components, wire up account creation with redux

* make requested style changes on inputs

* add automatic login

* Error display and createAccount adjustments

- Adjust error display css
- Close createaccount if user is signed in

* let checkbox highlight on focus, add firstname and lastname required fields

* refactor input to have a single help text line

* Add tests for createAccount

* revert create account

* Tests for createAccount form

* tests checkbox and fix other specs

* prettier pass

* revert to single helptext line

* update package-lock to please circleCI

* update package-lock and package.json

* use browser persistence instead of interacting directly with local storage

* add TODO and fix indents

* Rename accountCreation variables

* add autocomplete to input

* Remove mock account

* set default username and replace Form component with Informed's Form

* start switch to Text component from Informed

* switch to dot lookup in navigation states

* Set initial value of CreateAccount (inform)

* prettier pass and some test fixes

* Merge / Prettier / Lint

* start merge with 2.0 release

* remove debugger

* modify user actions/reducers to be in release 2.0 format

* get tests running for cart actions

* write tests for async User actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants