Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed HTML special characters issue #985

Closed

Conversation

yogeshsuhagiya
Copy link
Member

Description

Fixed HTML special characters issue for the product name on the category page and product view page.

Related Issue

#984

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

screenshot

Proposed Labels for Change Type/Package

Checklist:

  • I have read the CONTRIBUTING document.
  • I have linked an issue to this PR.
  • I have indicated the change type and relevant package(s).
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All CI checks are green (linting, build/deploy, etc).
  • At least one core contributor has approved this PR.

@vercel
Copy link

vercel bot commented Mar 4, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@vercel vercel bot temporarily deployed to staging March 4, 2019 06:18 Inactive
@supernova-at
Copy link
Contributor

There were some duplicate commits on this PR too.

Kindly let me know if I've missed anything 👍 .

@yogeshsuhagiya
Copy link
Member Author

Hi @sirugh, can you please review this PR now? All checks have passed.

@sirugh
Copy link
Contributor

sirugh commented Mar 7, 2019

@yogeshsuhagiya something seems off with the commits. Can you remove any commits not made by you for this change? @supernova-at may be able to help.

@yogeshsuhagiya
Copy link
Member Author

yogeshsuhagiya commented Mar 8, 2019

Hi @supernova-at, how I can remove commits of other peoples?
The following commits do not belong to my PR.
7c93cdc
94610e0
ce472b3

@yogeshsuhagiya
Copy link
Member Author

@supernova-at, @sirugh Guys, please let me know what I've to do next to move this PR ahead?

@sirugh
Copy link
Contributor

sirugh commented Mar 11, 2019

@yogeshsuhagiya if the changeset you made here is small enough I would suggest closing this PR and reopening a new branch made off the latest develop branch. Then you can cherry-pick or just reproduce your changes and push them up. That's probably the easiest route here.

@sirugh sirugh mentioned this pull request Mar 11, 2019
8 tasks
@sirugh
Copy link
Contributor

sirugh commented Mar 11, 2019

Replaced with #1010

@sirugh sirugh closed this Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants