Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]: Adjust get image details to the latest MediaGallery update. #1136

Closed
wants to merge 4 commits into from
Closed

[WIP]: Adjust get image details to the latest MediaGallery update. #1136

wants to merge 4 commits into from

Conversation

coderimus
Copy link
Contributor

@coderimus coderimus commented Apr 6, 2020 •
edited by sivaschenko
Loading

Description (*)

This PR will provide changes to the View Details functionality after the magento/magento2#27499 will be merged.

Depends on: #1235

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Apr 6, 2020
sivaschenko
sivaschenko requested changes Apr 15, 2020
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @coderimus thanks for the pull request! Can you please update the branch and resolve conflicts.

Also, please take a look on recently merged changes in #1175

@m2-community-project m2-community-project bot moved this from Ready for Review to Changes Requested in Pull Request Progress Apr 15, 2020
@coderimus
Copy link
Contributor Author

@sivaschenko thank you for the mentioned PR: magento/magento2#27499
I also merged 1.1-develop to the PR's branch and see that changes provided by me do not have practical value. However, I do not want to close this PR because when the magento/magento2#27499 will be merged I can adjust view details to the newly provided changes.

@coderimus coderimus changed the title Improve get image details by asset id by refactoring and covering wit… [WIP]: Adjust get image details to the latest MediaGallery update. Apr 16, 2020
@sivaschenko
Copy link
Member

@coderimus magento/magento2#27499 is merged, however, there is another dependency: #1235

@coderimus
Copy link
Contributor Author

I close this PR because of asset details already implemented.

@coderimus coderimus closed this Apr 24, 2020
@ghost
Copy link

ghost commented Apr 24, 2020

Hi @coderimus, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot removed this from Changes Requested in Pull Request Progress Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko requested changes

Assignees

@sivaschenko sivaschenko

Labels
Backend Community Insider: Magecom community-insider-contribution Progress: changes requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coderimus @sivaschenko @magento-engcom-team