Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated MediaGallery modules and marked as API #27499

Merged
merged 44 commits into from
Apr 19, 2020
Merged

Updated MediaGallery modules and marked as API #27499

merged 44 commits into from
Apr 19, 2020

Conversation

sivaschenko
Copy link
Member

@sivaschenko sivaschenko commented Mar 30, 2020 •
edited
Loading

Description (*)

MediaGallery/MediaGalleryApi module services introduced in 2.3.4 are marked as API.
Also, the following services for operations with media files and directories were added:

  • \Magento\MediaGalleryApi\Model\Directory\ExcludedInterface
  • \Magento\MediaGalleryApi\Model\Directory\Command\DeleteByPathInterface
  • \Magento\MediaGalleryApi\Model\Directory\Command\CreateByPathInterface

Related Pull Requests

magento/adobe-stock-integration#1158

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 30, 2020

Hi @sivaschenko. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added this to Pending Review in Pull Requests Dashboard Mar 30, 2020
@sivaschenko
Copy link
Member Author

@naydav @joni-jones please review this pull request

@ghost ghost assigned joni-jones Mar 30, 2020
@ghost ghost assigned sivaschenko Mar 30, 2020
sidolov
sidolov previously approved these changes Apr 1, 2020
View reviewed changes
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Apr 1, 2020
@ghost ghost assigned sidolov Apr 1, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-7242 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

naydav
naydav requested changes Apr 1, 2020
View reviewed changes
app/code/Magento/MediaGallery/Model/Directory/Command/CreateByPath.php Outdated Show resolved Hide resolved
app/code/Magento/MediaGallery/Model/Directory/Command/CreateByPath.php Outdated Show resolved Hide resolved
app/code/Magento/MediaGallery/Model/Directory/Command/CreateByPath.php Outdated Show resolved Hide resolved
app/code/Magento/MediaGallery/Model/Directory/Command/DeleteByPath.php Outdated Show resolved Hide resolved
app/code/Magento/MediaGalleryApi/Model/File/Command/DeleteByAssetIdInterface.php Outdated Show resolved Hide resolved
app/code/Magento/MediaGalleryApi/Model/Directory/ExcludedInterface.php Outdated Show resolved Hide resolved
app/code/Magento/MediaGalleryApi/Model/Directory/Command/DeleteByPathInterface.php Outdated Show resolved Hide resolved
app/code/Magento/MediaGalleryApi/Model/Directory/Command/CreateByPathInterface.php Outdated Show resolved Hide resolved
app/code/Magento/MediaGallery/Model/Directory/Excluded.php Outdated Show resolved Hide resolved
app/code/Magento/MediaGallery/Model/Directory/Excluded.php Outdated Show resolved Hide resolved
@ghost ghost moved this from Ready for Testing to Changes Requested in Pull Requests Dashboard Apr 1, 2020
@ghost ghost assigned naydav Apr 1, 2020
@ghost ghost dismissed sidolov’s stale review April 1, 2020 17:02

Pull Request state was updated. Re-review required.

@sivaschenko sivaschenko mentioned this pull request Apr 15, 2020
Merged
4 tasks
@sivaschenko sivaschenko mentioned this pull request Apr 16, 2020
Closed
@coderimus coderimus mentioned this pull request Apr 16, 2020
Closed
@lenaorobei
Copy link
Contributor

lenaorobei commented Apr 16, 2020 •
edited
Loading

Performance build: https://bamboo.corp.magento.com/browse/MCCE24-MCCE24404-1

@sivaschenko
Copy link
Member Author

PAT is green

coderimus
coderimus reviewed Apr 17, 2020
View reviewed changes
dev/tests/integration/testsuite/Magento/MediaGallery/_files/media_asset_rollback.php

try {
$mediaAssetDelete->execute('testDirectory/path.jpg');
} catch (\Exception $exception) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sivaschenko https://github.com/magento/adobe-stock-integration/pull/1188/files/9041038e8c3232997f94744031813009a6a7635a#r410128808

@sivaschenko
Copy link
Member Author

@magento run all tests

@sivaschenko
Copy link
Member Author

The pull request was tested using basic Media Gallery functionality in Adobe Stock Integration

@magento-engcom-team magento-engcom-team merged commit 371be02 into magento:2.4-develop Apr 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 19, 2020

Hi @sivaschenko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sidolov sidolov removed this from Changes Requested in Pull Requests Dashboard Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maghamed maghamed maghamed left review comments

@joni-jones joni-jones joni-jones left review comments

@coderimus coderimus coderimus left review comments

@VladimirZaets VladimirZaets VladimirZaets left review comments

@naydav naydav naydav requested changes

@buskamuza buskamuza buskamuza approved these changes

@sidolov sidolov sidolov left review comments

@slavvka slavvka Awaiting requested review from slavvka

Assignees

@naydav naydav

@buskamuza buskamuza

@maghamed maghamed

@sivaschenko sivaschenko

@joni-jones joni-jones

@VladimirZaets VladimirZaets

@sidolov sidolov

Labels
Component: MediaGallery Progress: needs update Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@sivaschenko @magento-engcom-team @maghamed @lenaorobei @naydav @buskamuza @joni-jones @coderimus @VladimirZaets @sidolov