Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCLOUD-3180 update the Configuration management topic #7147

Merged
merged 5 commits into from
May 14, 2020

Conversation

hguthrie
Copy link
Contributor

@hguthrie hguthrie commented May 2, 2020

This pull request (PR) provides extensive updates to the Cloud configuration management information.

  • walked through the config dump process and updated the topic according to 2.3.5 Cloud project behavior
  • fixed broken links caused by the extensive topic update

Affected DevDocs pages

Configuration management for store settings

Remaining tasks

  • technical review
  • editorial review
  • update whatsnew

whatsnew
Updated the Cloud guide Configuration management for store settings topic.

fixed broken links due to extensive updates
@hguthrie hguthrie added Major Update Significant original updates to existing content Internal Dev Differentiates work between community and Magento staff labels May 2, 2020
@hguthrie hguthrie self-assigned this May 2, 2020
src/cloud/live/sens-data-initial.md Outdated Show resolved Hide resolved
src/cloud/live/sens-data-initial.md Show resolved Hide resolved
src/cloud/live/sens-data-initial.md Show resolved Hide resolved
src/cloud/live/sens-data-over.md Outdated Show resolved Hide resolved
src/cloud/live/sens-data-over.md Show resolved Hide resolved
src/cloud/live/sens-data-over.md Outdated Show resolved Hide resolved
src/cloud/live/sens-data-over.md Outdated Show resolved Hide resolved
src/cloud/live/sens-data-over.md Outdated Show resolved Hide resolved
@@ -35,7 +35,7 @@ For all Starter environments and Pro Integration environments, pushing your Git
- [`.magento.env.yaml`]({{ site.baseurl }}/cloud/project/magento-env-yaml.html)—centralizes the management of build and deploy actions across all of your environments, including Pro Staging and Production, using environment variables.
- [`.magento/routes.yaml`]({{ site.baseurl }}/cloud/project/project-conf-files_routes.html)—defines how Magento processes an incoming URL.
- [`.magento/services.yaml`]({{ site.baseurl }}/cloud/project/project-conf-files_services.html)—defines the services Magento uses by name and version. For example, this file may include versions of MySQL, PHP extensions, and Elasticsearch. These are referred to as *services*.
- [`app/etc/config.php`]({{ site.baseurl }}/cloud/live/sens-data-over.html)—defines the [system-specific settings]({{ site.baseurl }}/cloud/live/sens-data-over.html#cloud-clp-settings) Magento uses to configure your store. Magento auto-generates this file if it does not detect it during the build phase and includes a list of modules and extensions. If the file exists, the build phase continues as normal, compresses static files using `gzip`, and deploys the files. If you follow [Configuration Management]({{ site.baseurl }}/cloud/live/sens-data-over.html) at a later time, the commands update the file without requiring additional steps.
- [`app/etc/config.php`]({{ site.baseurl }}/cloud/live/sens-data-over.html)—defines the [system-specific settings]({{ site.baseurl }}/cloud/live/sens-data-over.html#configuration-data) Magento uses to configure your store. Magento auto-generates this file if it does not detect it during the build phase and includes a list of modules and extensions. If the file exists, the build phase continues as normal, compresses static files using `gzip`, and deploys the files. If you follow [Configuration Management]({{ site.baseurl }}/cloud/live/sens-data-over.html) at a later time, the commands update the file without requiring additional steps.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the commands update ... what commands?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. This was only a link update.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a description of the config.php file for configuration management, which is what this PR is about.

1. Open the `config.local.php` file and copy the contents.

1. Paste the contents into the `config.php` file, save, and complete adding it to Git.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Paste the contents into the `config.php` file, save, and complete adding it to Git.
1. Paste the contents into the `config.php` file, save, and then commit and push the change to the remote environment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is the section that I requested more information for in the MCLOUD ticket. I have no idea what is going on here.

@hguthrie
Copy link
Contributor Author

@meker12 It looks like you merged master into my branch? Why?

@meker12
Copy link
Contributor

meker12 commented May 13, 2020

@meker12 It looks like you merged master into my branch? Why?

I built a new staging preview for the additional review request in Slack, and I always update branches to master before I build those. Sorry for stepping on your branch.

@hguthrie
Copy link
Contributor Author

@meker12 It looks like you merged master into my branch? Why?

I built a new staging preview for the additional review request in Slack, and I always update branches to master before I build those. Sorry for stepping on your branch.

Yes, please do not do that in the future. I do not use merge to update a branch, especially while in review. Thanks.

src/cloud/live/sens-data-initial.md Outdated Show resolved Hide resolved
@@ -35,7 +35,7 @@ For all Starter environments and Pro Integration environments, pushing your Git
- [`.magento.env.yaml`]({{ site.baseurl }}/cloud/project/magento-env-yaml.html)—centralizes the management of build and deploy actions across all of your environments, including Pro Staging and Production, using environment variables.
- [`.magento/routes.yaml`]({{ site.baseurl }}/cloud/project/project-conf-files_routes.html)—defines how Magento processes an incoming URL.
- [`.magento/services.yaml`]({{ site.baseurl }}/cloud/project/project-conf-files_services.html)—defines the services Magento uses by name and version. For example, this file may include versions of MySQL, PHP extensions, and Elasticsearch. These are referred to as *services*.
- [`app/etc/config.php`]({{ site.baseurl }}/cloud/live/sens-data-over.html)—defines the [system-specific settings]({{ site.baseurl }}/cloud/live/sens-data-over.html#cloud-clp-settings) Magento uses to configure your store. Magento auto-generates this file if it does not detect it during the build phase and includes a list of modules and extensions. If the file exists, the build phase continues as normal, compresses static files using `gzip`, and deploys the files. If you follow [Configuration Management]({{ site.baseurl }}/cloud/live/sens-data-over.html) at a later time, the commands update the file without requiring additional steps.
- [`app/etc/config.php`]({{ site.baseurl }}/cloud/live/sens-data-over.html)—defines the [system-specific settings]({{ site.baseurl }}/cloud/live/sens-data-over.html#configuration-data) Magento uses to configure your store. Magento auto-generates this file if it does not detect it during the build phase and includes a list of modules and extensions. If the file exists, the build phase continues as normal, compresses static files using `gzip`, and deploys the files. If you follow [Configuration Management]({{ site.baseurl }}/cloud/live/sens-data-over.html) at a later time, the commands update the file without requiring additional steps.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a description of the config.php file for configuration management, which is what this PR is about.

@hguthrie
Copy link
Contributor Author

running tests

@hguthrie hguthrie merged commit 74c3764 into master May 14, 2020
@ghost
Copy link

ghost commented May 14, 2020

Hi @hguthrie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@hguthrie
Copy link
Contributor Author

YAY! Merged! Thank you @meker12 for help reviewing!

@meker12 meker12 deleted the hg-mc3180-config branch May 22, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants