GraphQL: Add gift message attributes to Cart #7441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keharper
added
Internal Dev
keharper
changed the title
|
@rogyar I added you as a reviewer because you're probably familiar with the development effort. I'm aware that magento/magento2#27956 added more data types/attributes to the GiftMessage schema, but I'll hold off on adding them now, |
dobooth
approved these changes
Jun 26, 2020
Pull Request Progress
automation
moved this from Review in Progress
to Reviewer Approved
Jun 26, 2020
|
Looks good. Please note that we have another PR with a similar purpose |
rogyar
approved these changes
Jul 3, 2020
|
running tests |
|
Hi @keharper, thank you for your contribution! |
m2-community-project
bot
moved this from Reviewer Approved
to Done
in Pull Request Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) adds attributes to the
Cartobject that were added in magento/magento2#27956Affected DevDocs pages
and others