GraphQL GiftMessageGraphQl add coverage for cart

[Usik2203]

Description (*)

This PR extends the existing GraphQl coverage by adding information about gift message to different types of cart items.

Please note, this PR does not cover the entire gift wrapping functionality but resolvers for the gift message. The rest of the git wrapping functionality will be delivered with the others PR

Note: These types were not extended because these types are not declared

 
type GiftCardCartItem {
    gift_message: GiftMessage @doc(description: "The entered gift message for the cart item")
}

type SalesItemInterface {
    gift_wrapping: GiftWrapping @doc(description: "The selected gift wrapping for the order item")
    gift_message: GiftMessage @doc(description: "The entered gift message for the order item")
}

type SalesTotalsInterface {
    gift_options: GiftOptionsPrices @doc(description: "The list of prices for the selected gift options")
}

This PR was mentioned for fixing failed static test related with composer.json file
#253

Related Pull Requests

#28072
#28105

Fixed Issues (if relevant)

1. GraphQL Checkout :: Add support for Gift Wrapping / Gift Message during checkout.

Manual testing scenarios (*)

You can use this query for manual testing. You should take maskedQuoteId from quote_id_mask table

{
    cart(cart_id: "maskedQuoteId") {
           gift_message {
               to
               from
               message
           }
      }
}

[m2-assistant]

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[rogyar]

Hi @Usik2203. Thank you for your collaboration. Please, check my comments, adjust the code style and you may proceed with the test coverage.

Thank you!

[rogyar]

The recipient, sender and message may have null value. In this case, we need to make sure that we have no exception because all 3 values are required (and have Sring type) in the schema. I would recommend using the null coalesce operator and return empty string in case of no value. i.e.

$giftCartMessage->getSender() ?? ''

[Usik2203]

Done

[rogyar]

We need to make sure that we need all these dependencies

[Usik2203]

Done

[rogyar]

I'm not sure we should extend this PR with more functionality. Let's leave the gift messages for different cart item types in this PR and cover all other functionality (mutations, gift wrapping) in the following PRs

[Usik2203]

I have removed it from this PR, will do it in other PR

[Usik2203]

@rogyar api-functional test was added for this PR.
Thank you for review.

[Usik2203]

@magento run Static Tests

[Usik2203]

@magento run Magento Health Index

[Usik2203]

@magento run Static Tests

[Usik2203]

@magento run Static Tests

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-7587 has been created to process this Pull Request

[paliarush]

Verified that no new @api or interfaces were introduced in scope of this PR, so approval by the architecture team is not required.

[engcom-Bravo]

✔️ QA Passed

The GraphQL query

query {
  cart(
    cart_id: "8T3x445Ys2Scga6yWHAGVP9GYUPR8ua2"
  ) {
    gift_message {
      from
      message
      to
    }
  }
}

returns

{
  "data": {
    "cart": {
      "gift_message": {
        "from": "From",
        "message": "Message",
        "to": "To"
      }
    }
  }
}

[m2-assistant]

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.