-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud packages August release #7669
Conversation
* MCLOUD-6485: Add validator for braintree variable existence * Update src/cloud/project/project-conf-files_magento-app.md * Apply suggestions from code review Co-authored-by: Margaret Eker <meker@adobe.com>
* MCLOUD-6137: Mention error log file * MCLOUD-6221: Add specific error code in some steps * MCLOUD-6221: Add specific error code in some steps
* Error message updates: - Removed error suggestions data file which is replaced by error-codes.md file in the _includes directory - Added include file with error code tables generated from ece-tools source code - Renamed error-codes.md to ece-tools-error-reference.md and updated toc/cloud-guide.yml - Replaced embedded error code tables with _includes/cloud/error-codes.md - Added sample of cloud.errors.log entry (JSON string), updated log field descriptions to match the ones in the cloud.errors.log * Add renamed error message reference topic * Clarify that only cloud.error.log is in JSON format * Adding updated error code tables generated from ece-tools * MCLOUD-6530: Fix an issue with empty error code in the StepException (#7581) - Updated error-codes.md * Remove obsolete file * MCLOUD-6530: Fix an issue with empty error code in the StepException (#7582) * MCLOUD-6530: Fix an issue with empty error code in the StepException - Updated error-codes.md * MCLOUD-6530: Fix an issue with empty error code in the StepException - Updated error-codes.md * MCLOUD-6530: Fix an issue with empty error code in the StepException - Updated error-codes.md * Update src/_includes/cloud/error-codes.md Co-authored-by: hguthrie <hguthrie@users.noreply.github.com> * Update src/cloud/project/log-locations.md Co-authored-by: hguthrie <hguthrie@users.noreply.github.com> * Update src/cloud/reference/ece-tools-error-reference.md Co-authored-by: maeker12 <{ID}+{username}@users.noreply.github.com> Co-authored-by: Oleksandr Shmyheliuk <oshmyheliuk@magento.com> Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>
* Added release notes * Added JIRA ticket number
Updated release date variable to TBD
…nto Cloud-packages-release
* MCLOUD-5624: Unable to enable sending email in the docker * Update src/cloud/docker/docker-config.md Co-authored-by: Margaret Eker <meker@adobe.com> * Update src/cloud/docker/docker-config.md Co-authored-by: Margaret Eker <meker@adobe.com> * Added line break * Added release note for HogMail service support on Cloud Docker * Editorial update Co-authored-by: Margaret Eker <meker@adobe.com>
to apply them - Added Patches release notes for MCLOUD-6139, MCLOUD-6110, MCLOUD-6588 - Added ece-tools release notes for MCLOUD-5878, MCLOUD-5879, MCLOUD-6221 MCLOUD-6375 - Added QUALITY_PATCHES variable to build variables with note about internal-only user
The link you provide to the error reference is : https://devdocs.magento.com/cloud/reference/ece-tools-error-reference.html Also, you have some mismatched titling with this topic that really needs some clarification and normalizing. The Navigation says |
The file name for the error message reference changes, so the new file is Updated the topic title to "Error message reference for ece-tools. |
- MCLOUD-5624 - MCLOUD-6621 - MCLOUD-6424 Co-authored-by: maeker12 <{ID}+{username}@users.noreply.github.com>
@@ -23,7 +23,7 @@ If you use Microsoft Windows, take the following steps before continuing: | |||
1. To enable Xdebug for your Docker environment, generate the Docker Compose configuration file in developer mode with the `--with-xdebug` option and any other required options, for example. | |||
|
|||
```bash | |||
vendor/bin/ece-docker build:compose --mode --sync-engine="mutagen" developer --with-xdebug | |||
vendor/bin/ece-docker build:compose --mode developer --sync-engine="mutagen" --with-xdebug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest having same format for all options:
--mode="developer" --sync-engine="mutagen" --with-xdebug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll end this, I can't finish just yet.
|
||
{:.bs-callout-warning} | ||
We do not recommend using Sendmail on CLI containers because the service can slow down the container creation process. | ||
When the MailHog service is installed, go to the following URL to open the service and view outgoing emails: `http://magento2.docker:8025` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would easier for readers to copy this URL if it were in a code block.
@@ -47,7 +47,7 @@ After upgrading, you can remove the `config.php` file and generate a new, comple | |||
|
|||
### Update the configuration file | |||
|
|||
If you are upgrading from an older version of Magento to 2.2.x or later, you must also update your [.magento.app.yaml] file or you might encounter errors. {{site.data.var.ece}} 2.2.x and later has new settings in the file. | |||
When you upgrade, you might need to update your [.magento.app.yaml] file to account for changes in the default configuration settings that are sometimes introduced to support changes in {{site.data.var.ece}} or the Magento application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why brackets around the .magento.app.yml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a link.
- /cloud/reference/error-codes.html | ||
--- | ||
|
||
This error message reference provides information to troubleshoot errors that can occur during the {{site.data.var.ece }} buid, deploy, and post-deploy processes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"provides information on..." "build"
- {:.new}Added the **QUALITY_PATCHES** environment variable to specify one or more patches to apply during the deployment process. Currently, this variable is for Magento internal use only.<!--MCLOUD-6375--> | ||
|
||
## v2002.1.1 | ||
*Release date: June 25, 2020*<br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blank line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like they aren't used after headers in release notes.
<style> | ||
table.docker-service-versions-table td:nth-child(2) { | ||
width: 500px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to close the style tag?
Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>
running tests |
Hi @meker12, thank you for your contribution! |
Purpose of this pull request
Documentation updates for the Cloud packages August 2020 release
Affected DevDocs pages
whatsnew
Published release notes and documentation updates for the June 2020 Magento Cloud packages release: