Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL: New mutations for managing customers #7673

Merged
merged 5 commits into from
Aug 19, 2020
Merged

GraphQL: New mutations for managing customers #7673

merged 5 commits into from
Aug 19, 2020

Conversation

keharper
Copy link
Contributor

@keharper keharper commented Aug 4, 2020 •
edited
Loading

Purpose of this pull request

This pull request (PR) adds documentation for the createCustomerV2, updateCustomerV2, and updateCustomerPassword mutations. The createCustomer and updateCustomer mutations have been deprecated.

Code PR: magento/magento2#28888
Code issue: magento/magento2#28570

Affected DevDocs pages

  • guides/v2.4/graphql/mutations/create-customer-v2.html
  • guides/v2.4/graphql/mutations/update-customer-v2.html
  • guides/v2.4/graphql/mutations/update-customer-email.html

Links to Magento source code

  • ...

whatsnew
We have added the createCustomerV2 and updateCustomerV2 mutations to manage customer accounts. These new mutations require different input objects than the createCustomer and updateCustomer mutations. To change a customer's email address, use the new updateCustomerEmail mutation.

@keharper keharper added Internal Dev Differentiates work between community and Magento staff Community Docs impacted by community code contribution New Topic A major update published as an entirely new document 2.4.1 labels Aug 4, 2020
@keharper keharper self-assigned this Aug 4, 2020
@m2-community-project m2-community-project bot added this to Review in Progress in Pull Request Progress Aug 4, 2020
Pull Request Progress automation moved this from Review in Progress to Reviewer Approved Aug 4, 2020
erikmarr
erikmarr approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@erikmarr erikmarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a minor question.

src/guides/v2.4/graphql/mutations/create-customer-v2.md Outdated Show resolved Hide resolved
src/guides/v2.4/graphql/mutations/update-customer-v2.md Outdated Show resolved Hide resolved
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Review in Progress in Pull Request Progress Aug 12, 2020
cpartica
cpartica previously requested changes Aug 17, 2020
View reviewed changes
src/guides/v2.4/graphql/mutations/create-customer-v2.md Show resolved Hide resolved
src/guides/v2.4/graphql/mutations/create-customer-v2.md
}
) {
customer {
firstname
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you leave on purpose all possible customer fields?
I guess yes because it's an example
maybe add a comment in the example # client can add other optional fields in the query
you can add comments wtih # in any graphql query

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're just examples, not meant to show every possibility. Keeping the examples to typical and/or minimal use cases also helps maintain these examples, as I don't have to update the example each time an attribute is added.

@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Request Progress Aug 17, 2020
@keharper keharper dismissed cpartica’s stale review August 19, 2020 22:34

Dismissing review because requests aren't currently feasible.

Pull Request Progress automation moved this from Changes Requested to Reviewer Approved Aug 19, 2020
@keharper
Copy link
Contributor Author

running tests

@keharper keharper merged commit ca00b80 into 2.4.1-develop Aug 19, 2020
@ghost
Copy link

ghost commented Aug 19, 2020

Hi @keharper, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Aug 19, 2020
@keharper keharper deleted the kh_customer-v2 branch August 22, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar left review comments

@erikmarr erikmarr erikmarr approved these changes

@cpartica cpartica cpartica left review comments

Assignees

@rogyar rogyar

@keharper keharper

@cpartica cpartica

@erikmarr erikmarr

Labels
2.4.1 Community Docs impacted by community code contribution Internal Dev Differentiates work between community and Magento staff New Topic A major update published as an entirely new document
Projects
Pull Request Progress
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@keharper @rogyar @cpartica @erikmarr